Add an option to disable case-sensitive routing #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 similar comments
|
@mcollina this looks perfect, could just do with a note maybe in the README? |
|
Done. |
robinglen
reviewed
Jun 30, 2018
README.md
Outdated
| @@ -75,6 +75,19 @@ const router = require('find-my-way')({ | |||
| allowUnsafeRegex: true | |||
| }) | |||
| ``` | |||
|
|
|||
| According to [RFC3986](https://tools.ietf.org/html/rfc3986#section-6.2.2.1find-my-way), Fastify is case sensitive by default. | |||
There was a problem hiding this comment.
Think the anchor is wrong, includes find-my-way after the section number
delvedor
reviewed
Jul 2, 2018
index.js
Outdated
| @@ -308,6 +320,9 @@ Router.prototype.lookup = function lookup (req, res) { | |||
| } | |||
|
|
|||
| Router.prototype.find = function find (method, path, version) { | |||
| if (!this.caseSensitive) { | |||
There was a problem hiding this comment.
if (this.caseSensitive === false)?
It should make V8 happier (but I'm not super sure because the value is already a Boolean).
delvedor
reviewed
Jul 2, 2018
|
@delvedor updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See fastify/fastify#1007.
@thearegee would this work for you?