Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "exports.types" for strict mode TS support #95

Merged
merged 1 commit into from
Oct 29, 2022

Conversation

dilame
Copy link
Contributor

@dilame dilame commented Oct 10, 2022

Without this change i get

TS7016: Could not find a declaration file for module 'hpagent'.
'/Users/bowzee/WebstormProjects/trading.bot/node_modules/hpagent/index.mjs' implicitly has an 'any' type.
Try `npm i --save-dev @types/hpagent` if it exists or add a new declaration (.d.ts) file containing `declare module 'hpagent';`

Maxim-Mazurok added a commit to Maxim-Mazurok/google-api-typings-generator that referenced this pull request Oct 17, 2022
@Maxim-Mazurok
Copy link

Can confirm that this closes #95 thanks!

@Maxim-Mazurok
Copy link

Would be great if you could edit the description to include closes #95 to link them

@mrl5
Copy link

mrl5 commented Oct 29, 2022

I can confirm that I also experience bug described in #94 and indeed the fix introduced in this PR solves it.

It would be nice to merge and release this oneliner already :D friendly ping @delvedor

thanks @Maxim-Mazurok for reporting and @dilame for fixing!

@delvedor delvedor changed the title chore(package.json): add "exports.types" for strict mode TS support add "exports.types" for strict mode TS support Oct 29, 2022
@delvedor delvedor merged commit 318afd7 into delvedor:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants