Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ead redirect loop #112

Merged
merged 2 commits into from Nov 11, 2021
Merged

Fix: ead redirect loop #112

merged 2 commits into from Nov 11, 2021

Conversation

DavidvtWout
Copy link
Contributor

@DavidvtWout DavidvtWout commented Nov 11, 2021

When no result is found for a query in the tree API with an inventoryID, you are redirected to the first result page. When the inventoryID is invalid, it can create a redirectloop, see #111.

This pull-request returns a 404 when the first page returns zero results.

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #112 (8eed6cd) into master (52e22f4) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   30.58%   30.59%           
=======================================
  Files         133      133           
  Lines       14716    14719    +3     
=======================================
+ Hits         4501     4503    +2     
- Misses       9930     9932    +2     
+ Partials      285      284    -1     
Flag Coverage Δ
unittests 30.59% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub3/server/http/handlers/search.go 0.00% <0.00%> (ø)
hub3/fragments/resource.go 24.80% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e22f4...8eed6cd. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kiivihal kiivihal merged commit 8ae9cac into delving:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants