-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds dropwizard metrics, overhaul of how application is initialized #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-time dependency injection' which is akin to Spring Java Config. Doing so has exposed the org.OrgContext companion object for what it is: a holder of configuration and singleton instances that gets passed around between anyone and everyone. One by one, each property of the OrgContext class should be removed until every component is only injected with exactly the values or collaborators it requires. Metrics are now available on /non-public/monitoring/metrics. When deploying this application you should disallow users to that url using nginx, apache etc.
Remove useless 'logBulkApi' switch.
…t-time. Keep it as a member of the to-be-removed OrgContext for now as an intermediary step.
…gActor-actorref was created more than once, which Akka does not like.
hanswesterbeek
changed the title
Adds dropwizzard metrics, overhaul of how application is initialized
Adds dropwizard metrics, overhaul of how application is initialized
Aug 18, 2016
I have been testing this pull-request and ran into an issue during the initial PMH harvest:
|
How to reproduce? |
…ecome apparent when you hit them at runtime. Thank you, Play Framework!
Obtained repro-scenario out of band and verified through UI that it works. @kiivihal the ball is in your court again :) |
Current coverage is 0.00% (diff: 0.00%)@@ develop #82 diff @@
=====================================
Files 50 52 +2
Lines 51 3934 +3883
Methods 0 0
Messages 0 0
Branches 3 159 +156
=====================================
Hits 0 0
- Misses 51 3934 +3883
Partials 0 0
|
I have verified that the harvesting and incremental harvesting now works again. I will merge this pull-request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated to use of play 2.4-recommended dependency injection, 'compile-time' variant. That means far less static classes, greater testability and the ability to keep upgrading Play, as they are sure to deprecate '
object
' components.Did not use the run-time variant (which relies on Guice) because it is unneeded and requires programmers to learn another framework.
Note: Considering the fact that the init-overhaul is so fundamental, a full re-test of the app is required before merging this branch. I have processed the 'first' sip.zip with success. Works on my machine :)