Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streams won't render correct with shaders #84

Open
ghost opened this issue Aug 2, 2019 · 9 comments
Open

Streams won't render correct with shaders #84

ghost opened this issue Aug 2, 2019 · 9 comments

Comments

@ghost
Copy link

ghost commented Aug 2, 2019

Im using Sildurs Shaders but this is with every other too
I cant see any Errors in the Log an the Block.properties gets loaded correctly

[Client thread/INFO] [Config]: [OptiFine] [Shaders] Parsing block mappings: streams:shaders/block.properties

I can Post the full Log if you want to
Edit: Some Shaders load the Water but it has no Flow it looks like static water

2019-08-02_18 30 46

@meegoreng
Copy link

Temporary fix: open the mod's .jar file as an archive and edit the block.properties file, which should look like this:

block.8=streams:river/tile.water/-2/-2 streams:river/tile.water/-2/-1 streams:river/tile.water/-2/0 streams:river/tile.water/-2/1 streams:river/tile.water/-2/2 streams:river/tile.water/-1/-2 streams:river/tile.water/-1/2 streams:river/tile.water/0/-2 streams:river/tile.water/0/0 streams:river/tile.water/0/2 streams:river/tile.water/1/-2 streams:river/tile.water/1/2 streams:river/tile.water/2/-2 streams:river/tile.water/2/-1 streams:river/tile.water/2/0 streams:river/tile.water/2/1 streams:river/tile.water/2/2

block.13000=streams:river/tile.water/-2/-2 streams:river/tile.water/-2/-1 streams:river/tile.water/-2/0 streams:river/tile.water/-2/1 streams:river/tile.water/-2/2 streams:river/tile.water/-1/-2 streams:river/tile.water/-1/2 streams:river/tile.water/0/-2 streams:river/tile.water/0/0 streams:river/tile.water/0/2 streams:river/tile.water/1/-2 streams:river/tile.water/1/2 streams:river/tile.water/2/-2 streams:river/tile.water/2/-1 streams:river/tile.water/2/0 streams:river/tile.water/2/1 streams:river/tile.water/2/2

changing the first line from block.8 to block.10008 fixes it for me, which should give you

block.10008=streams:river/tile.water/-2/-2 streams:river/tile.water/-2/-1 streams:river/tile.water/-2/0 streams:river/tile.water/-2/1 streams:river/tile.water/-2/2 streams:river/tile.water/-1/-2 streams:river/tile.water/-1/2 streams:river/tile.water/0/-2 streams:river/tile.water/0/0 streams:river/tile.water/0/2 streams:river/tile.water/1/-2 streams:river/tile.water/1/2 streams:river/tile.water/2/-2 streams:river/tile.water/2/-1 streams:river/tile.water/2/0 streams:river/tile.water/2/1 streams:river/tile.water/2/2

block.13000=streams:river/tile.water/-2/-2 streams:river/tile.water/-2/-1 streams:river/tile.water/-2/0 streams:river/tile.water/-2/1 streams:river/tile.water/-2/2 streams:river/tile.water/-1/-2 streams:river/tile.water/-1/2 streams:river/tile.water/0/-2 streams:river/tile.water/0/0 streams:river/tile.water/0/2 streams:river/tile.water/1/-2 streams:river/tile.water/1/2 streams:river/tile.water/2/-2 streams:river/tile.water/2/-1 streams:river/tile.water/2/0 streams:river/tile.water/2/1 streams:river/tile.water/2/2

this probably can be fixed really easily in the next update

@ghost
Copy link
Author

ghost commented Sep 3, 2019

Now it will render It but it appears as static water and not as a stream With moving water

@swiftbird07
Copy link

Now it will render It but it appears as static water and not as a stream With moving water

Yep, have the exact same problem now.

@spacecowgirl314
Copy link

I came to here to say this an issue too. The mod looks great but this is a deal breaker for me.

@delvr
Copy link
Owner

delvr commented Jan 15, 2020

This one is a bit tricky, because depending on the mod's block.properties configuration I can only support one set of shaders at a time. Currently using block ID 8 we have support for BSL, and using block ID 10008 as suggested by @meegoreng we have support for Sildurs. SEUS seems to work OK in both cases depending on version. Using macro directives in the config doesn't work as it can only switch on things like Minecraft version of shader capabilities, not on shader name. It looks like the only way to make this work would be to ship different Streams jars for different shaders, and this might be a maintenance headache.

Regarding water not flowing: very few shaders display water currents currently, I know SEUS did in 10.1 by overlaying the vanilla moving lines, but it stopped doing so in 11.0. This isn't specific to Streams, if you look at regular vanilla flowing water you'll probably see no current in most shaders, you just know it flows based on looking at the angles of the blocks. So I don't think Streams can do anything about this unfortunately.

@xemnes
Copy link

xemnes commented Nov 18, 2020

thought id add to this, i think it should be up to the end user to add the compatibility themselves, they just need to add support via the shaderpacks block.properties which isnt much of a task at all. find the line for water and add the lines mentioned above.
as for flowing water, its entirely up to the shader how they want it to look. go for a shader that applies the water texture to the surface, bsl and complementary has the option to do this in shader options, with biome colour support aswell.

also bsl quite recently changed their line for water to 10300
not sure why.

the best thing you can do really is to instruct users who have the problem via some sort of faq.

@OnceSan
Copy link

OnceSan commented Apr 11, 2021

re
do you know what it would be for bsl shaders?

@xemnes
Copy link

xemnes commented Apr 11, 2021

my comment explains what it is and how to do it for bsl.

@Technoguyfication
Copy link

I fixed this by extracting my shaderpack, opening the block.properties file, finding the appropriate line for my game version, and adding the following to it:

BSL_v8.2.01 on 1.12.2

streams:river/tile.water/-2/-2 streams:river/tile.water/-2/-1 streams:river/tile.water/-2/0 streams:river/tile.water/-2/1 streams:river/tile.water/-2/2 streams:river/tile.water/-1/-2 streams:river/tile.water/-1/2 streams:river/tile.water/0/-2 streams:river/tile.water/0/0 streams:river/tile.water/0/2 streams:river/tile.water/1/-2 streams:river/tile.water/1/2 streams:river/tile.water/2/-2 streams:river/tile.water/2/-1 streams:river/tile.water/2/0 streams:river/tile.water/2/1 streams:river/tile.water/2/2

The entire line now looks like this:

block.10300= \
minecraft:water minecraft:flowing_water streams:river/tile.water/-2/-2 streams:river/tile.water/-2/-1 streams:river/tile.water/-2/0 streams:river/tile.water/-2/1 streams:river/tile.water/-2/2 streams:river/tile.water/-1/-2 streams:river/tile.water/-1/2 streams:river/tile.water/0/-2 streams:river/tile.water/0/0 streams:river/tile.water/0/2 streams:river/tile.water/1/-2 streams:river/tile.water/1/2 streams:river/tile.water/2/-2 streams:river/tile.water/2/-1 streams:river/tile.water/2/0 streams:river/tile.water/2/1 streams:river/tile.water/2/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants