New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible Spelling/Grammar/Typos #54

Closed

6 tasks done

jrhea opened this issue Oct 27, 2021 · 0 comments · Fixed by #56

Closed

6 tasks done

Possible Spelling/Grammar/Typos #54

jrhea opened this issue Oct 27, 2021 · 0 comments · Fixed by #56

Contributor

jrhea commented Oct 27, 2021 •

edited

Loading

CoreVoting.sol

Comity spelled wrong

https://github.com/element-fi/council/blob/d371ac82184fc26e19e958bd0b861f83e74b2955/contracts/CoreVoting.sol#L105

Timelock.sol

Comity should be spelled committee

https://github.com/element-fi/council/blob/d371ac82184fc26e19e958bd0b861f83e74b2955/contracts/features/Timelock.sol#L22

History.sol

blocknumber user (Not sure what this means)

https://github.com/element-fi/council/blob/d371ac82184fc26e19e958bd0b861f83e74b2955/contracts/libraries/History.sol#L147

spelling: minium -> minimum

https://github.com/element-fi/council/blob/d371ac82184fc26e19e958bd0b861f83e74b2955/contracts/libraries/History.sol#L280

OptimisticRewards.sol

Should be “would take effect” (not affect)

https://github.com/element-fi/council/blob/d371ac82184fc26e19e958bd0b861f83e74b2955/contracts/vaults/OptimisticRewards.sol#L53

VestingVault.sol

Spelling: olyManager modifier -> onlyManager modifier

https://github.com/element-fi/council/blob/d371ac82184fc26e19e958bd0b861f83e74b2955/contracts/vaults/VestingVault.sol#L74

jrhea mentioned this issue

minor spelling/typo fixes #56

Merged

jrhea closed this as completed in #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment