Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Us/poc multiple - 2 dernières actions de l'onglet suivi #8433

Merged
merged 6 commits into from
Jan 16, 2023

Conversation

lisa-durand
Copy link
Contributor

Mise en place des 2 dernières actions de l'onglet "suivi" : "repasser en construction" et "ne plus suivre"
Voir #8076

Capture d’écran 2023-01-13 à 15 39 12

@lisa-durand lisa-durand marked this pull request as draft January 13, 2023 14:40
@@ -13,9 +13,9 @@ def render?
def operations_for_dossier(dossier)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchak petit doute sur le principe de se baser sur l'etat des dossiers car ça ne fonctionne pas vraiment pour les actions follow / unfollow il me semble

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est pour ça qu'on passe tout le dossier dans cette méthode. Pour certains cas il faudra être plus malin que juste l'état.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ou alors toujours autoriser ces actions pour tous les états (comme ce que tu fais là) et juste rendre l'action idempotente pour follow/unfollow. Je pense que ça serait une bonne option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai fait ça 6f93713, je ne sais pas si c'est ce que tu avais en tête ? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je me suis permis de merger - je te laisse proposer une PR de refacto si au final ça ne te convient pas.

@lisa-durand lisa-durand force-pushed the US/poc-multiple-last-2-actions-page-suivis branch from 905fc24 to 6f93713 Compare January 16, 2023 09:59
@lisa-durand lisa-durand marked this pull request as ready for review January 16, 2023 09:59
@lisa-durand lisa-durand requested a review from mfo January 16, 2023 10:00
Copy link
Contributor

@mfo mfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est canon !

@lisa-durand lisa-durand merged commit eadd84b into main Jan 16, 2023
@lisa-durand lisa-durand deleted the US/poc-multiple-last-2-actions-page-suivis branch January 16, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants