-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Us/poc multiple - 2 dernières actions de l'onglet suivi #8433
Conversation
@@ -13,9 +13,9 @@ def render? | |||
def operations_for_dossier(dossier) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchak petit doute sur le principe de se baser sur l'etat des dossiers car ça ne fonctionne pas vraiment pour les actions follow / unfollow il me semble
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est pour ça qu'on passe tout le dossier dans cette méthode. Pour certains cas il faudra être plus malin que juste l'état.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ou alors toujours autoriser ces actions pour tous les états (comme ce que tu fais là) et juste rendre l'action idempotente pour follow
/unfollow
. Je pense que ça serait une bonne option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'ai fait ça 6f93713, je ne sais pas si c'est ce que tu avais en tête ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je me suis permis de merger - je te laisse proposer une PR de refacto si au final ça ne te convient pas.
e9e6bfc
to
905fc24
Compare
…peration. sinon c'est un autre instructeur qui est crée
905fc24
to
6f93713
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c'est canon !
Mise en place des 2 dernières actions de l'onglet "suivi" : "repasser en construction" et "ne plus suivre"
Voir #8076