Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instructeur] Include SIRET informations in dossiers export #3046

Merged
merged 1 commit into from
Dec 5, 2018
Merged

[Instructeur] Include SIRET informations in dossiers export #3046

merged 1 commit into from
Dec 5, 2018

Conversation

tchak
Copy link
Member

@tchak tchak commented Nov 22, 2018

No description provided.

@tchak tchak force-pushed the dossier-export-service branch 2 times, most recently from b44cc92 to 2798199 Compare November 26, 2018 17:56
@tchak tchak mentioned this pull request Nov 26, 2018
Merged
@tchak tchak force-pushed the dossier-export-service branch 3 times, most recently from 8b9c98e to 512047d Compare November 27, 2018 16:15
@tchak tchak mentioned this pull request Nov 27, 2018
Closed
@tchak tchak requested a review from mmagn November 28, 2018 16:09
@tchak tchak force-pushed the dossier-export-service branch 3 times, most recently from c434743 to 551d18c Compare November 29, 2018 14:32
kemenaran
kemenaran reviewed Dec 3, 2018
View reviewed changes
Copy link
Contributor

@kemenaran kemenaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

À

app/services/procedure_export_service.rb Show resolved Hide resolved
app/services/procedure_export_service.rb Show resolved Hide resolved
app/services/procedure_export_service.rb Show resolved Hide resolved
spec/services/procedure_export_service_spec.rb Show resolved Hide resolved
@tchak tchak force-pushed the dossier-export-service branch 2 times, most recently from 20176b1 to 3171248 Compare December 5, 2018 14:05
@tchak tchak changed the title [WIP] Procedure export dossiers with champs siret Procedure export dossiers with champs siret Dec 5, 2018
@tchak
Copy link
Member Author

tchak commented Dec 5, 2018

up @kemenaran

@kemenaran
Copy link
Contributor

kemenaran commented Dec 5, 2018 •
edited

En essayant d'exporter en ODS les dossiers d'une démarche créé chez moi, je prends une erreur :

capture d ecran 2018-12-05 a 16 37 42

(Peut-être ça pourrait être intéressant de mettre un test d'acceptance là dessus – pas forcément pour vérifier le contenu du fichier, mais pour être sûr qu'on ne plante pas en le générant)

@kemenaran
Copy link
Contributor

Sinon LGTM

@tchak
Copy link
Member Author

tchak commented Dec 5, 2018

@kemenaran up avec un smoke test

@kemenaran kemenaran changed the title Procedure export dossiers with champs siret [Instructeur] Include SIRET informations in dossiers export Dec 5, 2018
@tchak tchak merged commit d1825b7 into demarches-simplifiees:dev Dec 5, 2018
@fredZen fredZen mentioned this pull request Dec 5, 2018
Merged
@kemenaran kemenaran mentioned this pull request Dec 18, 2018
Closed
@tchak tchak deleted the dossier-export-service branch May 14, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemenaran kemenaran kemenaran approved these changes

@mmagn mmagn Awaiting requested review from mmagn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tchak @kemenaran