- clean up the, very odd, code around #externalProperties

demarey · Jul 14, 2020 · 26d325f · 26d325f
1 parent dab76db
commit 26d325f
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 62 deletions.
diff --git a/src/GT-Spotter/GTSpotterExtensionSettings.class.st b/src/GT-Spotter/GTSpotterExtensionSettings.class.st
@@ -14,15 +14,6 @@ Class {
 	#category : #'GT-Spotter-Model'
 }
 
-{ #category : #settings }
-GTSpotterExtensionSettings class >> defaultStateOf: aMethod [
-
-	"I return the default state of a given spotter extension, so the settings can be correctly created"
-	"All methods are active but "
-
-	^ (aMethod methodClass = Object and: [ aMethod selector = #spotterRePropertiesFor: ]) not
-]
-
 { #category : #private }
 GTSpotterExtensionSettings class >> disabledExtensions [
 	^ disabledExtensions ifNil: [ disabledExtensions := Set new ]

diff --git a/src/GT-Spotter/Object.extension.st b/src/GT-Spotter/Object.extension.st
@@ -105,17 +105,3 @@ Object >> spotterProcessorsFor: aSpotterStep pragma: aPragma [
 	(aSpotterStep processors last: addedProcessorsSize)
 		do: [ :processor | processor order: (aPragma argumentAt: 1) ] 
 ]
-
-{ #category : #'*GT-Spotter' }
-Object >> spotterRePropertiesFor: aStep [
-	<spotterOrder: 0>
-
-	ReSettings spotterPlugin ifFalse: [ ^ self ].
-
-	aStep listProcessor
-		title: 'Renraku Properties';
-		items: [ self externalProperties asArray ];
-		itemName: #title;
-		itemIcon: #icon;
-		filter: GTFilterSubstring
-]
diff --git a/src/Renraku/ClassDescription.extension.st b/src/Renraku/ClassDescription.extension.st
@@ -28,7 +28,6 @@ ClassDescription >> banLevelCandidates [
 
 { #category : #'*renraku' }
 ClassDescription >> critiques [
-	<eProperty>
 	^ ReCriticEngine critiquesOf: self
 ]
 

diff --git a/src/Renraku/CompiledMethod.extension.st b/src/Renraku/CompiledMethod.extension.st
@@ -29,7 +29,6 @@ CompiledMethod >> banLevelCandidates [
 
 { #category : #'*renraku' }
 CompiledMethod >> critiques [
-	<eProperty>
 	| critiques |
 
 	critiques := ReCriticEngine critiquesOf: self.

diff --git a/src/Renraku/Object.extension.st b/src/Renraku/Object.extension.st
@@ -30,33 +30,3 @@ Object >> glmCritiqueSourceIn: composite [
 
 	"display nothing for now"
 ]
-
-{ #category : #'*renraku' }
-Object >> gtInspectorEProportiesIn: composite [
-	"This provides a list of all external properties"
-
-	<gtInspectorPresentationOrder: 20>
-	| eProperties ePropLazy |
-
-	ReSettings inspectorPluggin ifFalse: [ ^ self ].
-
-	ePropLazy := [
-		eProperties ifNil: [ eProperties := self externalProperties ] ].
-
-	composite list
-		when: [ ePropLazy value notEmpty ];
-		title: [ ePropLazy value size asString, (' property' asPluralBasedOn: ePropLazy value) ];
-		titleIcon: [ CircleMorph new
-				extent: 16 @ 16;
-				borderWidth: 0;
-				color: Color red darker darker;
-				addMorphCentered:
-					(ePropLazy value size asStringMorph
-						color: Color white;
-						emphasis: 1;
-						yourself);
-				iconOrThumbnail ];
-		display: [ ePropLazy value ];
-		icon: #icon;
-		format: #title
-]
diff --git a/src/Renraku/RBProgramNode.extension.st b/src/Renraku/RBProgramNode.extension.st
@@ -24,8 +24,6 @@ RBProgramNode >> banLevelCandidates [
 
 { #category : #'*renraku' }
 RBProgramNode >> critiques [
-	<eProperty>
-
 	^ ReCriticEngine critiquesOf: self
 ]
 

diff --git a/src/Renraku/RGMethodDefinition.extension.st b/src/Renraku/RGMethodDefinition.extension.st
@@ -2,8 +2,5 @@ Extension { #name : #RGMethodDefinition }
 
 { #category : #'*renraku' }
 RGMethodDefinition >> critiques [
-
-	<eProperty>
-
 	^ self compiledMethod critiques
 ]
diff --git a/src/Renraku/RPackage.extension.st b/src/Renraku/RPackage.extension.st
@@ -28,8 +28,6 @@ RPackage >> banLevelCandidates [
 
 { #category : #'*renraku' }
 RPackage >> critiques [
-	<eProperty>
-
 	^ ReCriticEngine critiquesOf: self
 ]