Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail with perl 5.16.3 on linux. #8

Closed
jeteve opened this issue Jan 3, 2014 · 5 comments
Closed

Fail with perl 5.16.3 on linux. #8

jeteve opened this issue Jan 3, 2014 · 5 comments

Comments

@jeteve
Copy link

jeteve commented Jan 3, 2014

Hi,

Building this fails with perl 5.16.3

see http://www.cpantesters.org/cpan/report/376392de-535c-11e3-a8f2-ae50d605dcb9

I pinned it down to

-Expected
+Result
@30,30 (30)
= };

  • bless( $HASH1->{JSB}, 'JSON::XS::Boolean' );
  • bless( $HASH1->{JSB}, 'JSON::PP::Boolean' );

For test at line 295

For some reason, JSON::XS::decode_json("true"); gives a JSON::PP::Boolean

$ perl -MJSON::XS -MData::Dumper -e 'print Dumper(JSON::XS::decode_json("true"));'
$VAR1 = bless( do{(my $o = 1)}, 'JSON::PP::Boolean' );

My JSON::XS version is 3.01

Interesting stuff:

https://metacpan.org/pod/JSON::PP::Boolean#NOTES-FOR-XS-USERS

Filing this for now, more details may follow :)

Cheers,

Jerome.

@jeteve
Copy link
Author

jeteve commented Jan 6, 2014

This is mentionned here too https://rt.cpan.org/Public/Bug/Display.html?id=90311

@demerphq
Copy link
Owner

demerphq commented Jan 6, 2014

Sorry about this, I have been too busy to roll a new DDS release. Trying to
find time to do it soon.

On 6 January 2014 10:19, Jerome Eteve notifications@github.com wrote:

This is mentionned here too
https://rt.cpan.org/Public/Bug/Display.html?id=90311


Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-31635722
.

perl -Mre=debug -e "/just|another|perl|hacker/"

@jeteve
Copy link
Author

jeteve commented Jan 7, 2014

What about fixing it by making the test to adapt to whatever sort of class
JSON::XS::decode_json("true") returns?

I'm happy doing it.

Cheers.

@jeteve
Copy link
Author

jeteve commented Jan 7, 2014

Code change is in pull request #9

@demerphq
Copy link
Owner

demerphq commented Feb 1, 2014

IIRC this is done. Thanks for the report and patch.

@demerphq demerphq closed this as completed Feb 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants