Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Initial Integrating Catnapw with Regression System #389

Merged
merged 3 commits into from
Dec 29, 2022
Merged

[ci] Initial Integrating Catnapw with Regression System #389

merged 3 commits into from
Dec 29, 2022

Conversation

ppenna
Copy link
Contributor

@ppenna ppenna commented Dec 28, 2022 •
edited

Description

Summary of Changes

  • Integrated Catnapw building with our regression system.
    • Building is enabled on dev branch only, because the GitHub Actions plugin that we use does not support passing environment variables to a Windows remote.
  • Disabled C format checking on Windows, because it is not implemented.
  • Wrote a documentation with Build instructions for Windows.

@ppenna ppenna added bug Something Isn't Working enhancement Enhancement Request on an Existing Feature documentation Improvements or Additions to Documentation labels Dec 28, 2022
@ppenna ppenna self-assigned this Dec 28, 2022
anandbonde
anandbonde approved these changes Dec 29, 2022
View reviewed changes
Copy link
Contributor

@anandbonde anandbonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ppenna ppenna merged commit dc661c9 into dev Dec 29, 2022
@ppenna ppenna deleted the enhancement-test-ci-catnapw branch December 29, 2022 13:49
@ppenna ppenna changed the title [ci] Initial Integration of Catnapw with Regression System [ci] Initial Integrating Catnapw with Regression System Dec 29, 2022
@ppenna ppenna mentioned this pull request Dec 29, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandbonde anandbonde anandbonde approved these changes

Assignees

@ppenna ppenna

Labels
bug Something Isn't Working documentation Improvements or Additions to Documentation enhancement Enhancement Request on an Existing Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ppenna @anandbonde