Skip to content

Commit

Permalink
Google drive includeshared issue (#26014)
Browse files Browse the repository at this point in the history
* Added the include_items_from_all_drives argument

* Added release notes

* Made the field in populate fields case insensitive

* Updated the release notes

* Updated docker image in the readme

* Updated readme
  • Loading branch information
gal-forer committed Apr 24, 2023
1 parent 276fb6d commit 0e1df8c
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 2 deletions.
1 change: 1 addition & 0 deletions Packs/GoogleDrive/Integrations/GoogleDrive/GoogleDrive.py
Original file line number Diff line number Diff line change
Expand Up @@ -940,6 +940,7 @@ def prepare_file_read_request(client: 'GSuiteClient', args: Dict[str, str]) -> D
pageSize=args.get('page_size'),
pageToken=args.get('page_token'),
supportsAllDrives=args.get('supports_all_drives'),
includeItemsFromAllDrives=args.get('include_items_from_all_drives')
)

# user_id can be overridden in the args
Expand Down
26 changes: 25 additions & 1 deletion Packs/GoogleDrive/Integrations/GoogleDrive/GoogleDrive.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2075,6 +2075,18 @@ script:
description: Query string for searching shared drives.
required: false
isArray: false
- auto: PREDEFINED
default: false
defaultValue: "false"
description: 'Whether both My Drive and shared drive items should be included
in the results. Possible values: "true" and "false".'
isArray: false
name: include_items_from_all_drives
predefined:
- "true"
- "false"
required: false
secret: false
- name: user_id
description: The user's primary email address.
required: false
Expand Down Expand Up @@ -2131,6 +2143,18 @@ script:
description: The user's primary email address.
required: false
isArray: false
- auto: PREDEFINED
default: false
defaultValue: "false"
description: 'Whether both My Drive and shared drive items should be included
in the results. Possible values: "true" and "false".'
isArray: false
name: include_items_from_all_drives
predefined:
- "true"
- "false"
required: false
secret: false
- name: fields
description: The fields you want included in the response.
required: false
Expand Down Expand Up @@ -3220,7 +3244,7 @@ script:
- "false"
required: false
secret: false
dockerimage: demisto/googleapi-python3:1.0.0.54895
dockerimage: demisto/googleapi-python3:1.0.0.55166
feed: false
isfetch: true
longRunning: false
Expand Down
2 changes: 2 additions & 0 deletions Packs/GoogleDrive/Integrations/GoogleDrive/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -706,6 +706,7 @@ Lists the user's shared drives.
| user_id | The user's primary email address. | Optional |
| fields | The fields you want included in the response. Default is kind, id, name, mimeType, description, starred, trashed, explicitlyTrashed, trashingUser, trashedTime, parents, properties, appProperties, spaces, version, webContentLink, webViewLink, iconLink, hasThumbnail, thumbnailLink, thumbnailVersion, viewedByMe, viewedByMeTime, createdTime, modifiedTime, modifiedByMeTime, modifiedByMe, sharedWithMeTime, sharingUser, owners, teamDriveId, driveId, lastModifyingUser, shared, ownedByMe, capabilities, viewersCanCopyContent, copyRequiresWriterPermission, writersCanShare, permissions, permissionIds, hasAugmentedPermissions, folderColorRgb, originalFilename, fullFileExtension, fileExtension, md5Checksum, size, quotaBytesUsed, headRevisionId, contentHints, isAppAuthorized, exportLinks, shortcutDetails, contentRestrictions, resourceKey, linkShareMetadata. | Optional |
| supports_all_drives | Whether the requesting application supports both My Drives and shared drives. Possible values are: True, False. Default is False. | Optional |
| include_items_from_all_drives | Whether both My Drive and shared drive items should be included in the results. Possible values: "true" and "false". Possible values are: true, false. Default is false. | Optional |


#### Context Output
Expand Down Expand Up @@ -740,6 +741,7 @@ Get a single file.
| file_id | ID of the requested file. Can be retrieved using the `google-drive-files-list` command. | Optional |
| user_id | The user's primary email address. | Optional |
| fields | The fields you want included in the response. Default is kind, id, name, mimeType, description, starred, trashed, explicitlyTrashed, trashingUser, trashedTime, parents, properties, appProperties, spaces, version, webContentLink, webViewLink, iconLink, hasThumbnail, thumbnailLink, thumbnailVersion, viewedByMe, viewedByMeTime, createdTime, modifiedTime, modifiedByMeTime, modifiedByMe, sharedWithMeTime, sharingUser, owners, teamDriveId, driveId, lastModifyingUser, shared, ownedByMe, capabilities, viewersCanCopyContent, copyRequiresWriterPermission, writersCanShare, permissions, permissionIds, hasAugmentedPermissions, folderColorRgb, originalFilename, fullFileExtension, fileExtension, md5Checksum, size, quotaBytesUsed, headRevisionId, contentHints, isAppAuthorized, exportLinks, shortcutDetails, contentRestrictions, resourceKey, linkShareMetadata. | Optional |
| include_items_from_all_drives | Whether both My Drive and shared drive items should be included in the results. Possible values: "true" and "false". Possible values are: true, false. Default is false. | Optional |


#### Context Output
Expand Down
6 changes: 6 additions & 0 deletions Packs/GoogleDrive/ReleaseNotes/1_2_29.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### Google Drive

- Added the **include_items_from_all_drives** argument to **google-drive-files-list** and **google-drive-files-list** commands
2 changes: 1 addition & 1 deletion Packs/GoogleDrive/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "Google Drive",
"description": "Google Drive allows users to store files on their servers, synchronize files across devices, and share files. This integration helps you to create a new drive, query past activity and view change logs performed by the users, as well as list drives and files, and manage their permissions.",
"support": "xsoar",
"currentVersion": "1.2.28",
"currentVersion": "1.2.29",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down

0 comments on commit 0e1df8c

Please sign in to comment.