Skip to content

Commit

Permalink
Add new validate manager to builds (#31274)
Browse files Browse the repository at this point in the history
* added the new validate flow to the builds as a non-mandatory step.

Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>

---------

Co-authored-by: Judah Schwartz <JudahSchwartz@users.noreply.github.com>
  • Loading branch information
2 people authored and maimorag committed Jan 7, 2024
1 parent 2542b36 commit 7ff0c14
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
13 changes: 11 additions & 2 deletions .gitlab/ci/.gitlab-ci.global.yml
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,11 @@
- section_start "Validate Files and Yaml"
- |
./Tests/scripts/linters_runner.sh
./Tests/scripts/validate.sh
if [ $VALIDATE_SCRIPT == "old-validate-flow" ]; then
./Tests/scripts/validate.sh
else
./Tests/scripts/new_validate.sh
fi
- section_end "Validate Files and Yaml"
- section_start "Check Spelling"
- python3 ./Tests/scripts/circleci_spell_checker.py $CI_COMMIT_BRANCH
Expand All @@ -532,7 +536,12 @@
- section_end "Revoking GCP Auth"
- !reference [ .validate_content_test_conf_branch_merged ] # This section should be the last one in the script, do not move it.
- job-done

parallel:
matrix:
- VALIDATE_SCRIPT: ['old-validate-flow','new-validate-flow']
rules:
- if: '$VALIDATE_SCRIPT == "new-validate-flow"'
allow_failure: true
.jobs-done-check:
stage: are-jobs-really-done
extends:
Expand Down
6 changes: 4 additions & 2 deletions Tests/scripts/check_jobs_done.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
CONTENT_NIGHTLY_JOBS = [
'run-unittests-and-lint: [native:dev,from-yml]',
'run-unittests-and-lint: [native:ga,native:maintenance,native:candidate]',
'run-validations',
'run-validations: [old-validate-flow]',
'run-validations: [new-validate-flow]',
'trigger-private-build',
'mpv2-prepare-testing-bucket',
'xpanse-prepare-testing-bucket',
Expand Down Expand Up @@ -62,7 +63,8 @@
CONTENT_COMMON_JOBS = [
'run-unittests-and-lint: [native:dev,from-yml]',
'run-unittests-and-lint: [native:ga,native:maintenance,native:candidate]',
'run-validations',
'run-validations: [old-validate-flow]',
'run-validations: [new-validate-flow]',
'test-upload-flow',
'trigger-private-build',
'validate-content-conf',
Expand Down

0 comments on commit 7ff0c14

Please sign in to comment.