Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Cisco AMP Integration (#21994) * Cisco AMP Integration * Added integration to conf.json * Fixed indentations * Removed secrets from README.md * Removed secrets * format on yml file * Fixed according to validator * fixed docker image tag * Update image size * Improved event_type to not include None * demisto-sdk update-release-notes -i Packs/CiscoAMP * Ignore mypy error * Fixed mypy error position * Fixed fetch argument to max_fetch. Added API version to README. * Fixed default value for server url. removed releasenotes * Updated pack version * Changed argument name from 3rd to Third to avoid validation error. * Changed endpoint generic command to support arrays * Added walrus operator to an if statement * Update Packs/CiscoAMP/Integrations/CiscoAMP/CiscoAMP.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * Removed unnecessary line. Fixed `not in` to `!=`. * Update Packs/CiscoAMP/Integrations/CiscoAMP/CiscoAMP.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * Update Packs/CiscoAMP/Integrations/CiscoAMP/CiscoAMP.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * Update Packs/CiscoAMP/Integrations/CiscoAMP/CiscoAMP.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * Fixed `any` not receiving an iterable object. * Moved all raiseValue tests to another function. Fixed typo in function name is query. * Corrected format of exception handling within test * Added comment when neither manual and automatic pagination has been chosen * Removed type: ignores and added reason where needed. * Added reliability parameter and functionality. * Added helper function for trajectory commands. Added reliability param in test. * Changed reliability type to str * Added default values for pagination params * Added `type ignore` to `event_type` as it cannot be `List[Optional[int]]`. If it is None it will fall in the creation. If it isn't a number an exception will be raised in `arg_to_number`. * Added test for checking there are no links in outputs. * updated docker image tag * Update CiscoAMP_description.md Done. * Removed Integration commands from readme. * Updated docker image tag * Update README.md Done. * Update README.md Done. * Update CiscoAMP.yml Done. * Trying to fix an error from unit-test and lint validation: "/home/circleci/project/Packs/CiscoAMP/Integrations/CiscoAMP/CiscoAMP.yml", line 1837, column 595 * Update Packs/CiscoAMP/Integrations/CiscoAMP/CiscoAMP.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * Fixed error handling with HTTP response to use `res`. * Fixed SHA256 validation in event_list * Removed unneeded ignore statement. * Changed order of `if` statements when handling pagination types. * Fixed bug in `get_readable_output` when the items within a response is `None`. * Fixed bug, with new list set as 0. * Improved the `doc` description of `is_query_wrong`. * Improved `is_query_wrong` response `doc` * Added comment for unclear if statement in activity list * Added to the description of an error in case an item to delete is not found * Removed redundant if * Returned type ignore. * Fixed a bug in regex * Update docker image tag * Changed exception to DemistoException as requested in PR. * Added UNKOWN as default severity in fetch incidents. * Added comment to explain a logic in a test * Update Packs/CiscoAMP/Integrations/CiscoAMP/CiscoAMP.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> * Updated feature availability. * Enriched unit-test * Removed all 'in's from test functions and changed them to '==' as requested. * updated docker image tag * remade validate_query. * changed filename regex to a constant global. * Added headers to feature isolation test. * added test for last command_results in trajectory test * remade unit test expected output. * fixed long lines. * update docker image tag * Added a new method pagination_range that generates a range for pagination tuple. * Added DemistoException and removed unneeded defaults in pagination. * Changed a loop to list comprehension. * Fixed type hint * Removed a `try-except` block from `file_command`. Co-authored-by: LiorQM <lior.sb18@gmail.com> Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * skip * black Co-authored-by: LiorQM <106475467+LiorQM@users.noreply.github.com> Co-authored-by: LiorQM <lior.sb18@gmail.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
- Loading branch information