[pan-os-create-tag] without comment argument (#28263)

* revert the if for comment * fixed test
demisto · Jul 19, 2023 · dc9dc7e · dc9dc7e
1 parent a7c190f
commit dc9dc7e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/Packs/PAN-OS/Integrations/Panorama/Panorama.py b/Packs/PAN-OS/Integrations/Panorama/Panorama.py
@@ -13208,8 +13208,7 @@ def build_tag_element(disable_override: bool, comment: str, new_name: str = None
     if DEVICE_GROUP:
         if api_disable_override := 'yes' if disable_override else 'no':
             element = f'<disable-override>{api_disable_override}</disable-override>'
-    if comment:
-        element += f'<comments>{comment}</comments>'
+    element += f'<comments>{comment}</comments>'
     if color:
         element += f'<color>{color}</color>'
     if new_name:

diff --git a/Packs/PAN-OS/Integrations/Panorama/Panorama_test.py b/Packs/PAN-OS/Integrations/Panorama/Panorama_test.py
@@ -7078,13 +7078,13 @@ def test_pan_os_delete_tag_command(mocker, is_shared):
             "device_group",
             "",
             {"disable_override": True, "comment": ""},
-            "<disable-override>yes</disable-override>"
+            "<disable-override>yes</disable-override><comments></comments>"
         ),
         (
             "",
             "vsys1",
             {"disable_override": True, "comment": ""},
-            ""
+            "<comments></comments>"
         ),
     ]
 )

diff --git a/Packs/PAN-OS/ReleaseNotes/1_17_15.md b/Packs/PAN-OS/ReleaseNotes/1_17_15.md
@@ -0,0 +1,6 @@
+
+#### Integrations
+
+##### Palo Alto Networks PAN-OS
+
+- Fixed an issue where the ***pan-os-create-tag*** command didn't work without the *comment* argument for Firewall instances.
diff --git a/Packs/PAN-OS/pack_metadata.json b/Packs/PAN-OS/pack_metadata.json
@@ -2,7 +2,7 @@
     "name": "PAN-OS by Palo Alto Networks",
     "description": "Manage Palo Alto Networks Firewall and Panorama. Use this pack to manage Prisma Access through Panorama. For more information see Panorama documentation.",
     "support": "xsoar",
-    "currentVersion": "1.17.14",
+    "currentVersion": "1.17.15",
     "author": "Cortex XSOAR",
     "url": "https://www.paloaltonetworks.com/cortex",
     "email": "",