Skip to content

Commit

Permalink
[splunk] fix for proxy parameter wasn't parsed correctly (#26395)
Browse files Browse the repository at this point in the history
* added default for proxy

* rn

* docker

* rn for docker

* rn update
  • Loading branch information
bziser committed May 8, 2023
1 parent d2fcdbf commit fc48c08
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
2 changes: 1 addition & 1 deletion Packs/SplunkPy/Integrations/SplunkPy/SplunkPy.py
Expand Up @@ -2619,7 +2619,7 @@ def main(): # pragma: no cover
splunk_parse_raw_command()
sys.exit(0)
service = None
proxy = argToBoolean(params.get('proxy'))
proxy = argToBoolean(params.get('proxy', False))

connection_args = get_connection_args()

Expand Down
12 changes: 5 additions & 7 deletions Packs/SplunkPy/Integrations/SplunkPy/SplunkPy.yml
Expand Up @@ -113,7 +113,7 @@ configuration:
type: 15
section: Collect
hidden:
- marketplacev2
- marketplacev2
- additionalinfo: When selected, closing the Splunk notable event with a "Closed" status will close the Cortex XSOAR incident.
defaultvalue: 'false'
display: Close Mirrored Cortex XSOAR Incidents (Incoming Mirroring)
Expand All @@ -123,7 +123,7 @@ configuration:
section: Collect
advanced: true
hidden:
- marketplacev2
- marketplacev2
- display: Additional Splunk status labels to close on mirror (Incoming Mirroring)
name: close_extra_labels
required: false
Expand All @@ -145,7 +145,7 @@ configuration:
section: Collect
advanced: true
hidden:
- marketplacev2
- marketplacev2
additionalinfo: When selected, closing the Cortex XSOAR incident will close the Notable Event in Splunk.
defaultvalue: 'false'
- display: Trust any certificate (not secure)
Expand Down Expand Up @@ -391,9 +391,7 @@ script:
- False Positive - Inaccurate Data
- Other
- Undetermined
description: Disposition of the notable. If the more options exist on the server,
specifying the disposition as `disposition:#` will work in place of choosing
one of the default values from the list.
description: Disposition of the notable. If the more options exist on the server, specifying the disposition as `disposition:#` will work in place of choosing one of the default values from the list.
description: Updates existing notable events in Splunk ES.
execution: true
name: splunk-notable-event-edit
Expand Down Expand Up @@ -628,7 +626,7 @@ script:
- contextPath: Splunk.UserMapping.SplunkUser
description: Splunk user mapping.
type: String
dockerimage: demisto/splunksdk-py3:1.0.0.56501
dockerimage: demisto/splunksdk-py3:1.0.0.57580
isfetch: true
ismappable: true
isremotesyncin: true
Expand Down
7 changes: 7 additions & 0 deletions Packs/SplunkPy/ReleaseNotes/3_0_17.md
@@ -0,0 +1,7 @@

#### Integrations

##### SplunkPy

- Updated the Docker image to: *demisto/splunksdk-py3:1.0.0.57580*.
- Fixed an issue where proxy parameter wasn't parsed correctly in cases it was not checked.
2 changes: 1 addition & 1 deletion Packs/SplunkPy/pack_metadata.json
Expand Up @@ -2,7 +2,7 @@
"name": "Splunk",
"description": "Run queries on Splunk servers.",
"support": "xsoar",
"currentVersion": "3.0.16",
"currentVersion": "3.0.17",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down

0 comments on commit fc48c08

Please sign in to comment.