make jira more robust #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make jira more robust
JudahSchwartz
added a commit
that referenced
this pull request
May 23, 2022
JudahSchwartz
added a commit
that referenced
this pull request
May 23, 2022
DNRRomero
added a commit
to DNRRomero/xsoar
that referenced
this pull request
Mar 19, 2024
* Simplify fetch_incidents method to avoid duplicate incidents change alert ids to str to facilitate storage and comparison add set to avoid duplicates delete unnecessary timestamp fields in last_run reduce fetch_incidents to a single http call to alerts endpoint * Add PR comments on fixing type hints and polishing tests --------- Co-authored-by: Diego Ramirez <dramirez@zerofox.com>
merit-maita
pushed a commit
that referenced
this pull request
Apr 11, 2024
…33436) * fix duplicate alerts (#123) * Simplify fetch_incidents method to avoid duplicate incidents change alert ids to str to facilitate storage and comparison add set to avoid duplicates delete unnecessary timestamp fields in last_run reduce fetch_incidents to a single http call to alerts endpoint * Add PR comments on fixing type hints and polishing tests --------- Co-authored-by: Diego Ramirez <dramirez@zerofox.com> * fix pre-commit formatting issues * remove get_alert_attachment command remove get_alert_attachment_command to avoid confusing customers * Add notes append test * format according to autopep8 * Update app versioning and add release notes * Change release version to 2.0.0 due to breaking compatibility * Undo version bump to 2.0.0 as it was not required, move back to 1.3.1 and mark as breaking change * Restore get_alert_attachments command and mark as deprecated, as per PR comments * Add sort field for fetching alerts given last_modified_min_date
merit-maita
added a commit
that referenced
this pull request
Apr 11, 2024
…33912) * Improve Fetch incidents structure and add append notes funcitonality (#33436) * fix duplicate alerts (#123) * Simplify fetch_incidents method to avoid duplicate incidents change alert ids to str to facilitate storage and comparison add set to avoid duplicates delete unnecessary timestamp fields in last_run reduce fetch_incidents to a single http call to alerts endpoint * Add PR comments on fixing type hints and polishing tests --------- Co-authored-by: Diego Ramirez <dramirez@zerofox.com> * fix pre-commit formatting issues * remove get_alert_attachment command remove get_alert_attachment_command to avoid confusing customers * Add notes append test * format according to autopep8 * Update app versioning and add release notes * Change release version to 2.0.0 due to breaking compatibility * Undo version bump to 2.0.0 as it was not required, move back to 1.3.1 and mark as breaking change * Restore get_alert_attachments command and mark as deprecated, as per PR comments * Add sort field for fetching alerts given last_modified_min_date * pre-commit * added rn --------- Co-authored-by: Diego Ramirez R <dramirez@zerofox.com> Co-authored-by: merit-maita <49760643+merit-maita@users.noreply.github.com> Co-authored-by: merit-maita <meretmaayta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make jira more robust