Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intezer): add latest report command #12486

Merged
merged 5 commits into from May 4, 2021
Merged

feat(intezer): add latest report command #12486

merged 5 commits into from May 4, 2021

Conversation

davidt99
Copy link
Contributor

@davidt99 davidt99 commented May 2, 2021

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Description

Add get the latest available report of a file instead of analyzing it)

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 5.5.0
  • 6.0.0
  • 6.1.0
  • 6.2.0

Does it break backward compatibility?

  • Yes
  • No

Must have

  • Tests
  • Documentation

@CLAassistant
Copy link

CLAassistant commented May 2, 2021

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label May 2, 2021
@content-bot content-bot changed the base branch from master to contrib/intezer_master May 2, 2021 14:30
@content-bot content-bot requested a review from Itay4 May 2, 2021 14:30
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @Itay4 will know he can start review the proposed changes.

@content-bot
Copy link
Collaborator

The CircleCI check from your latest pushed commit was unsuccessful. @davidt99 take a look at the build by clicking this link.


Failed Build Steps

  • Validate Files and Yaml

Try and address the listed CircleCI build step failures at your earliest convenience. This will greatly expedite the process of getting your proposed changes merged into master. Happy coding and may the force be with you.

@davidt99
Copy link
Contributor Author

davidt99 commented May 2, 2021

@Itay4 Any chance I can get the exact error from circleci?

@Itay4
Copy link
Contributor

Itay4 commented May 2, 2021

@Itay4 Any chance I can get the exact error from circleci?

You can follow the link from the comment to CircleCI to see the errors

Also, please make sure to sign the CLA and fill the contribution registration form so we can the review process

@davidt99
Copy link
Contributor Author

davidt99 commented May 2, 2021

I'm missing the partner id in the CLA but I'm working on that.
Unfortunately, I can't sign-up to CircleCI without giving it access to my private repositories so I can't do that. Any option to make the builds public?

@Itay4
Copy link
Contributor

Itay4 commented May 2, 2021

I'm missing the partner id in the CLA but I'm working on that.
Unfortunately, I can't sign-up to CircleCI without giving it access to my private repositories so I can't do that. Any option to make the builds public?

it it public
you can set grant access to public only according to https://discuss.circleci.com/t/github-org-permissions-only-access-public-repos/30525/2

@content-bot
Copy link
Collaborator

The CircleCI build failed again. @davidt99 take a look at the build details here - and try and fix the issues so that we can merge your proposed changes as soon as possible.


Failed Build Steps

  • Validate Files and Yaml

@davidt99
Copy link
Contributor Author

davidt99 commented May 3, 2021

@Itay4 can you help me figure out what's wrong? when I run demisto-sdk update-release-notes -i Packs/Intezer/ it yields "Either no changes were found in Intezer pack or the changes found should not be documented in the release notes file If relevant changes were made, please commit the changes and rerun the command". I'm on my master branch with the changes above.

@content-bot
Copy link
Collaborator

The CircleCI build failed again. @davidt99 take a look at the build details here - and try and fix the issues so that we can merge your proposed changes as soon as possible.


Failed Build Steps

  • Validate Files and Yaml

@davidt99
Copy link
Contributor Author

davidt99 commented May 3, 2021

@Itay4 I fixed the tests and signed the CLA, we are good to go with the review.

Copy link
Contributor

@Itay4 Itay4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - added 2 minor comments

Packs/Intezer/Integrations/IntezerV2/README.md Outdated Show resolved Hide resolved
Packs/Intezer/Integrations/IntezerV2/IntezerV2.yml Outdated Show resolved Hide resolved
davidt99 and others added 2 commits May 4, 2021 19:06
Co-authored-by: Itay Keren <ikeren@paloaltonetworks.com>
Co-authored-by: Itay Keren <ikeren@paloaltonetworks.com>
@davidt99 davidt99 requested a review from Itay4 May 4, 2021 16:33
@Itay4 Itay4 merged commit 55b1aee into demisto:contrib/intezer_master May 4, 2021
Itay4 added a commit that referenced this pull request May 5, 2021
* feat(intezer): add latest report command (#12486)

* feat(intezer): add latest report command

* feat(intezer): add latest report command

* feat(intezer): add latest report command

* Update Packs/Intezer/Integrations/IntezerV2/IntezerV2.yml

Co-authored-by: Itay Keren <ikeren@paloaltonetworks.com>

* Update Packs/Intezer/Integrations/IntezerV2/README.md

Co-authored-by: Itay Keren <ikeren@paloaltonetworks.com>

Co-authored-by: Itay Keren <ikeren@paloaltonetworks.com>

* ignore https://www.intezer.com

Co-authored-by: davidt99 <davidtufik@gmail.com>
Co-authored-by: Itay Keren <ikeren@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! docs-approved Partner
Projects
None yet
5 participants