Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hidden key to old integration params #17554

Merged
merged 9 commits into from Feb 27, 2022

Conversation

YuvHayun
Copy link
Contributor

@YuvHayun YuvHayun commented Feb 8, 2022

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

added hidden key to old integration params

Does it break backward compatibility?

  • Yes
  • No

Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ShahafBenYakir
Copy link
Contributor

@YuvHayun Already approved this PR. Fix the status checks and merge.

@ShahafBenYakir ShahafBenYakir removed their request for review February 22, 2022 21:57
@YuvHayun
Copy link
Contributor Author

The build is failing because the integration is skipped in nightly, I need you to force merge it please.

@content-bot
Copy link
Collaborator

@content-bot
Copy link
Collaborator

The following integrations/tests were collected by the CI build but are currently skipped. The collected tests are related to this pull request and might be critical.:

@YuvHayun YuvHayun requested review from ShahafBenYakir and removed request for ShahafBenYakir February 27, 2022 13:54
@ShahafBenYakir ShahafBenYakir merged commit 5896907 into master Feb 27, 2022
@ShahafBenYakir ShahafBenYakir deleted the adding_credentials_set_support_sentinel_one_v2 branch February 27, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants