Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capitalization in outputs: Ivantiheat -> IvantiHeat #19139

Merged
merged 4 commits into from May 22, 2022

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@ali-sawyer

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

Fix capitalization in command outputs (change Ivantiheat to IvantiHeat so that the outputs match what is actually written to context. Otherwise, since context is case sensitive, selecting the outputs from the helper in the playbook editor does not work because the capitalization is wrong, leading to confusion.

Screenshots

Example from the current OOTB version of the integration – command ivanti-heat-object-create:

Outputs start with Ivantiheat with lowercase h:

Screen Shot 2022-05-11 at 4 19 04 PM

However, context path outputted from the integration code starts with IvantiHeat with capital H:

Screen Shot 2022-05-11 at 4 20 35 PM

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

* Fix capitalization in outputs: Ivantiheat -> IvantiHeat

* Add release notes

* Updated release notes

* Updated breaking changes json

* Update docker image

Co-authored-by: MLainer1 <maylainer96@gmail.com>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! Contribution Form Filled Whether contribution form filled or not. Community labels May 22, 2022
@content-bot content-bot requested a review from MLainer1 May 22, 2022 11:05
@content-bot
Copy link
Collaborator Author

The CircleCI check from your latest pushed commit was unsuccessful. @content-bot take a look at the build by clicking this link.


Failed Build Steps

  • Validate Files and Yaml

Try and address the listed CircleCI build step failures at your earliest convenience. This will greatly expedite the process of getting your proposed changes merged into master. Happy coding and may the force be with you.

@content-bot
Copy link
Collaborator Author

The CircleCI build failed again. @content-bot take a look at the build details here - and try and fix the issues so that we can merge your proposed changes as soon as possible.


Failed Build Steps

  • Validate Files and Yaml

@content-bot
Copy link
Collaborator Author

The following integrations/tests were collected by the CI build but are currently skipped. The collected tests are related to this pull request and might be critical.:

  • Ivanti Heat - Test - reason: Issue 26259

@MLainer1
Copy link
Contributor

This PR needs a force-merge due to breaking changes, and no-tests.

@yaakovi yaakovi merged commit 1798897 into master May 22, 2022
@yaakovi yaakovi deleted the contrib/ali-sawyer_ivanti-heat-capitalization branch May 22, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
4 participants