Core get-prevalence #19543
Merged
Core get-prevalence #19543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovi
approved these changes
Jun 26, 2022
| 'process': 'process_name', | ||
| 'cmd': 'process_command_line', | ||
| 'hash': 'sha256', | ||
| 'registry': 'key_name' |
There was a problem hiding this comment.
PEP8
Suggested change
| 'registry': 'key_name' | |
| 'registry': 'key_name', |
Comment on lines
108
to
109
| for i in range(len(keys)): | ||
| args_list.append({'key_name': keys[i], 'value_name': values[i]}) |
There was a problem hiding this comment.
This is python, not C.
Suggested change
| for i in range(len(keys)): | |
| args_list.append({'key_name': keys[i], 'value_name': values[i]}) | |
| for key, value in zip(keys, values): | |
| args_list.append({'key_name': key, 'value_name': value}) |
| type: Boolean | ||
| - contextPath: Core.AnalyticsPrevalence.Hash.data.global_prevalence | ||
| description: The global prevalence of the hash. | ||
| type: Unknown |
There was a problem hiding this comment.
update all output typing (unless they are not simple types)
Comment on lines
3118
to
3119
| predefined: | ||
| - '' |
There was a problem hiding this comment.
Suggested change
| predefined: | |
| - '' |
| description: Get the prevalence of an ip, identified by ip_address. | ||
| execution: false | ||
| hidden: false | ||
| name: core-get-IP-analytics-prevalence |
There was a problem hiding this comment.
commands should be all lower-case.
Suggested change
| name: core-get-IP-analytics-prevalence | |
| name: core-get-ip-analytics-prevalence |
Packs/Core/ReleaseNotes/1_3_0.md
Outdated
| - ***core-get-domain-analytics-prevalence*** | ||
| - ***core-get-process-analytics-prevalence*** | ||
| - ***core-get-registry-analytics-prevalence*** | ||
| - ***core-get-cmd-analytics-prevalence'*** |
There was a problem hiding this comment.
Suggested change
| - ***core-get-cmd-analytics-prevalence'*** | |
| - ***core-get-cmd-analytics-prevalence*** |
|
Link to the unit tests coverage report: |
|
The build failed on irrelevant tests in XSIAM |
PierrickV
pushed a commit
to SEKOIA-IO/Cortex-XSOAR-integration
that referenced
this pull request
Jul 11, 2022
* added new command * changes after access to API. * some changes * added prevalence command * more fixes * update RN * moved commands to IR instead of IOC * Added UT * Added UT * Added UT * validation and lint fixes * fix yml file * review fixes * validation err fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
https://jira-hq.paloaltonetworks.local/browse/CIAC-470
https://github.com/demisto/etc/issues/48080
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have