Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added inputs for the date field used for filtering #19859

Merged
merged 6 commits into from Jul 9, 2022
Merged

Added inputs for the date field used for filtering #19859

merged 6 commits into from Jul 9, 2022

Conversation

aburt-demisto
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

NA

Description

Improves the integration by giving the user an option to pull objects based on CreatedDate or LastModifiedDate

Screenshots

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! labels Jul 1, 2022
@content-bot content-bot changed the base branch from master to contrib/aburt-demisto_aburt-salesforce-indicators-improvements July 1, 2022 14:52
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @israelpoli will know he can start review the proposed changes.

@israelpoli
Copy link
Contributor

Hi @aburt-demisto
Thank you for your contribution,

Please take a look at the following points:

  1. Run demisto-sdk format -ud -i Packs/SalesforceIndicators/Integrations/SalesforceIndicators/SalesforceIndicators.yml.

  2. About the date_field:

  • In the case of required == true, see here and use with demisto-sdk update-release-notes -i Packs/SalesforceIndicators -u
    (major|minor|revision|documentation) -bc    ,
  • In the case of required == false run demisto-sdk update-release-notes -i Packs/SalesforceIndicators -u
    (major|minor|revision|documentation)     without the -bc flag, To create release notes and update pack_metadata.json.

@israelpoli israelpoli added the pending-contributor The PR is pending the response of its creator label Jul 4, 2022
@aburt-demisto
Copy link
Contributor Author

  1. demisto-sdk format -ud -i Packs/SalesforceIndicators/Integrations/SalesforceIndicators/SalesforceIndicators.yml

I didn't want this to be a breaking change, so have made it non-mandatory and the default value is LastModifiedDate.

@israelpoli
Copy link
Contributor

  1. demisto-sdk format -ud -i Packs/SalesforceIndicators/Integrations/SalesforceIndicators/SalesforceIndicators.yml

I didn't want this to be a breaking change, so have made it non-mandatory and the default value is LastModifiedDate.

Ok, that makes sense

So, please run the command:

demisto-sdk update-release-notes -i Packs / SalesforceIndicators -u
(major | minor | revision | documentation)

For ReleaseNotes file to be created and updated the pack_metadata.json file to 1.0.8

Thanks @aburt-demisto

israelpoli
israelpoli approved these changes Jul 9, 2022
View reviewed changes
Copy link
Contributor

@israelpoli israelpoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @aburt-demisto for your contribution

It seems great

@israelpoli israelpoli added docs-approved and removed pending-contributor The PR is pending the response of its creator labels Jul 9, 2022
@israelpoli israelpoli merged commit 0007a4d into demisto:contrib/aburt-demisto_aburt-salesforce-indicators-improvements Jul 9, 2022
@content-bot content-bot mentioned this pull request Jul 9, 2022
Merged
11 tasks
israelpoli added a commit that referenced this pull request Jul 10, 2022
@content-bot @aburt-demisto @israelpoli
Added inputs for the date field used for filtering (#19958)
b449482 
* Added inputs for the date field used for filtering (#19859)

* Added inputs for the date field used for filtering

* made date field non-mandatory

* Bumped revision

* Updated Docker image

* updated relaese notes

* corrections

* commit

Co-authored-by: Adam Burt - Demisto <53576129+aburt-demisto@users.noreply.github.com>
Co-authored-by: israelpolishook <ipolishuk@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@israelpoli israelpoli israelpoli approved these changes

Assignees

@israelpoli israelpoli

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
Milestone
No milestone
3 participants
@aburt-demisto @content-bot @israelpoli