Fix typo in inputs description for pan-os-custom-block-rule #20188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
content-bot
added
Community
Contribution Form Filled
content-bot
changed the base branch from
master
to
contrib/issolahma_Panorama-integration-typo
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @MosheEichler will know he can start review the proposed changes. |
|
@issolahma Thank you for your contribution! Nicely done, can you please update the release-notes? |
MosheEichler
approved these changes
Jul 24, 2022
| @@ -1604,15 +1604,15 @@ script: | |||
| name: rulename | |||
| required: true | |||
| - auto: PREDEFINED | |||
| description: Where to move the rule. Can be "before", "after", "top", or "bottom". If you specify "top" or "bottom", you need to supply the "dst" argument. | |||
| description: Where to move the rule. Can be "before", "after", "top", or "bottom". If you specify "before" or "afer", you need to supply the "dst" argument. | |||
There was a problem hiding this comment.
Suggested change
| description: Where to move the rule. Can be "before", "after", "top", or "bottom". If you specify "before" or "afer", you need to supply the "dst" argument. | |
| description: Where to move the rule. Can be "before", "after", "top", or "bottom". If you specify "before" or "after", you need to supply the "dst" argument. |
MosheEichler
requested changes
Jul 24, 2022
There was a problem hiding this comment.
Hi issolahma,
Thanks for contributing!
- Please see my comment about one type
- Please add a release notes with running the demisto-sdk update-release-notes command.
Please let me know when you done.
MosheEichler
added
the
pending-contributor
|
Hi MosheEichler and GuyAfik, |
MosheEichler
added
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/3322799 |
MosheEichler
approved these changes
Jul 24, 2022
MosheEichler
merged commit fc1e398
into
demisto:contrib/issolahma_Panorama-integration-typo
5 tasks
MosheEichler
added a commit
that referenced
this pull request
Jul 25, 2022
* Fix typo in inputs description for pan-os-custom-block-rule (#20188) * Fix typo in inputs description for pan-os-custom-block-rule * Fixed other same typo in description * fix typo * Add release note * Update Packs/PAN-OS/ReleaseNotes/1_14_12.md Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> * conflicts Co-authored-by: issolahma <22448610+issolahma@users.noreply.github.com> Co-authored-by: Guy Afik <53861351+GuyAfik@users.noreply.github.com> Co-authored-by: meichlerpanw <meichler@paloaltonetworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Description
There is a typo in the bloc "Panorama - Create custom block rule" for the "where" and "dst" inputs descriptions.
The "dst" input must be filled only if you choose "before" or "after" in the "where" input, but it says "top" or "bottom".
Screenshots
Does it break backward compatibility?