Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the default_value parameter to return it when unmatched. #20613

Merged
merged 5 commits into from Aug 22, 2022
Merged

Added the default_value parameter to return it when unmatched. #20613

merged 5 commits into from Aug 22, 2022

Conversation

spearmin10
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

Added the default_value parameter to return it when unmatched.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Aug 18, 2022
@content-bot content-bot changed the base branch from master to contrib/spearmin10_MapPattern August 18, 2022 02:56
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YuvHayun will know he can start review the proposed changes.

@content-bot content-bot added Community Contribution Form Filled Whether contribution form filled or not. labels Aug 18, 2022
YuvHayun
YuvHayun requested changes Aug 21, 2022
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ spearmin10, great job!
Please see my comments below - most of them are just to add some more informational documentation.

Please don't hesitate to contact me with any questions, I'm available both here and via slack.
Thanks again!

Packs/MapPattern/ReleaseNotes/1_0_6.md Outdated Show resolved Hide resolved
Packs/MapPattern/ReleaseNotes/1_0_6.md Outdated Show resolved Hide resolved
Packs/MapPattern/Scripts/MapPattern/MapPattern.py Outdated Show resolved Hide resolved
Packs/MapPattern/Scripts/MapPattern/README.md Outdated Show resolved Hide resolved
Packs/MapPattern/Scripts/MapPattern/MapPattern.yml Outdated Show resolved Hide resolved
@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Aug 21, 2022
@spearmin10
Copy link
Contributor Author

@YuvHayun Thank you for reviewing. I've fixed where you commented.

@YuvHayun YuvHayun removed the pending-contributor The PR is pending the response of its creator label Aug 21, 2022
YuvHayun
YuvHayun requested changes Aug 21, 2022
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 1 more small fix, thank you.

Packs/MapPattern/ReleaseNotes/1_0_6.md Outdated
Comment on lines 3 to 4
- **MapPattern**
- Fixed an issue where it returns successfully when a syntax error occurred.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **MapPattern**
- Fixed an issue where it returns successfully when a syntax error occurred.
- Fixed an issue where the script returned a success message when a syntax error occurred.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuvHayun OK, I've fixed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I was trying to give a different fix suggestion here.

@YuvHayun YuvHayun added the pending-contributor The PR is pending the response of its creator label Aug 21, 2022
YuvHayun
YuvHayun reviewed Aug 21, 2022
View reviewed changes
Packs/MapPattern/ReleaseNotes/1_0_6.md Outdated
@@ -0,0 +1,6 @@

#### Scripts
- **MapPattern**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **MapPattern**
##### MapPattern

Just this one small fix @spearmin10
Sorry for the misunderstanding and thx again!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuvHayun OK, fixed it.

@YuvHayun YuvHayun added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Aug 21, 2022
@content-bot
Copy link
Collaborator

content-bot commented Aug 21, 2022 •
edited

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/3508304

@YuvHayun YuvHayun added docs-approved and removed pending-contributor The PR is pending the response of its creator labels Aug 22, 2022
YuvHayun
YuvHayun approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@YuvHayun YuvHayun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

@YuvHayun YuvHayun merged commit 5354cb6 into demisto:contrib/spearmin10_MapPattern Aug 22, 2022
@content-bot content-bot mentioned this pull request Aug 22, 2022
Merged
11 tasks
YuvHayun pushed a commit that referenced this pull request Aug 22, 2022
@content-bot @spearmin10
Added the default_value parameter to return it when unmatched. (#20613
0e421c4 
) (#20680)

* Added the `default_value` parameter to return it when unmatched.

* Fixed where the reviewer commented.

* Fixed where the reviewer commented.

* Fixed the release note

* Fixed the RN

Co-authored-by: Masahiko Inoue <54964121+spearmin10@users.noreply.github.com>
@spearmin10 spearmin10 deleted the MapPattern branch August 23, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuvHayun YuvHayun YuvHayun approved these changes

Assignees

@YuvHayun YuvHayun

Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR.
Projects
None yet
Milestone
No milestone
3 participants
@spearmin10 @content-bot @YuvHayun