Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update scripts in CommonScripts to support python3 #20999

Merged
merged 80 commits into from Sep 22, 2022
Merged

Update scripts in CommonScripts to support python3 #20999

merged 80 commits into from Sep 22, 2022

Conversation

michal-dagan
Copy link
Contributor

@michal-dagan michal-dagan commented Sep 6, 2022 •
edited

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Update the script to support python3

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@bziser bziser marked this pull request as ready for review September 6, 2022 16:36
michal-dagan and others added 24 commits September 7, 2022 09:43
@michal-dagan
Convert from python2 to python3
a6e13f9
@michal-dagan
delete the previous files
8c7d2f6
@michal-dagan
update the dockerimage and test to support python3
e5c5991
@michal-dagan
convert to python3
5f60dcf
@michal-dagan
Merge remote-tracking branch 'origin/master' into SendEmailOnSLABreach
92fc653
@michal-dagan
update releaseNote
2b47d11
@michal-dagan
Merge remote-tracking branch 'origin/master' into MaliciousRatioReput…
71b3e7d 
…ation

# Conflicts:
#	Packs/CommonScripts/ReleaseNotes/1_7_29.md
@michal-dagan
update test and ReleaseNote
faa3ba7
@michal-dagan
Merge remote-tracking branch 'origin/master' into ResolveShortenedURL
b949adf
@michal-dagan
update test
501dfb3
@michal-dagan
Merge branch 'master' into FileToBase64List
322ec70
@michal-dagan
Merge branch 'master' into MaliciousRatioReputation
aec31dd
@michal-dagan
Merge branch 'master' into SendEmailOnSLABreach
0ebc0ee
@michal-dagan
convert from python2 to python3
13db387
@michal-dagan
Merge remote-tracking branch 'origin/master' into DisplayHTML
f5c385b
@michal-dagan
update dockerimage
ea3d685
@michal-dagan
Merge branch 'master' into FileToBase64List
58af20e
@michal-dagan
Merge branch 'master' into MaliciousRatioReputation
c5de2e7
@michal-dagan
update to requests library from urllib.request
bd585ea
@michal-dagan
Merge remote-tracking branch 'origin/master' into FileToBase64List
0236e89 
# Conflicts:
#	Packs/CommonScripts/ReleaseNotes/1_7_33.md
@michal-dagan
fix decode()
2823447
@michal-dagan
update releaseNotes
aacd3db
@michal-dagan
Merge remote-tracking branch 'origin/FileToBase64List' into FileToBas…
55d7374 
…e64List
@michal-dagan
Merge remote-tracking branch 'origin/master' into ResolveShortenedURL
fbbc802 
# Conflicts:
#	Packs/CommonScripts/ReleaseNotes/1_7_32.md
@michal-dagan michal-dagan changed the title MaliciousRatioReputation - Updated the script to support python3 Update scripts in CommonScripts to support python3 Sep 13, 2022
michal-dagan and others added 16 commits September 13, 2022 16:43
@michal-dagan
Merge remote-tracking branch 'origin/master' into MaliciousRatioReput…
c41bbb5 
…ation

# Conflicts:
#	Packs/CommonScripts/pack_metadata.json
@michal-dagan
update version
3052dcd
@michal-dagan
Merge remote-tracking branch 'origin/master' into MaliciousRatioReput…
32a23b8 
…ation
@michal-dagan
fix type
94d3993
@michal-dagan
fix type
31e244d
@michal-dagan
Merge remote-tracking branch 'origin/master' into MaliciousRatioReput…
0923528 
…ation
@michal-dagan
Merge remote-tracking branch 'origin/MaliciousRatioReputation' into M…
b52a69f 
…aliciousRatioReputation

# Conflicts:
#	Packs/CommonScripts/Scripts/ResolveShortenedURL/ResolveShortenedURL.yml
@michal-dagan
Merge branch 'master' into MaliciousRatioReputation
e3f5042
@michal-dagan
Merge remote-tracking branch 'origin/master' into MaliciousRatioReput…
57b5e7a 
…ation

# Conflicts:
#	Packs/CommonScripts/ReleaseNotes/1_7_56.md
#	Packs/CommonScripts/pack_metadata.json
@michal-dagan
update ReleaseNotes
147bf2a
@michal-dagan
Merge remote-tracking branch 'origin/MaliciousRatioReputation' into M…
a73a699 
…aliciousRatioReputation
@michal-dagan
Merge branch 'master' into MaliciousRatioReputation
2a65f22
@michal-dagan
Merge remote-tracking branch 'origin/master' into MaliciousRatioReput…
e03e6f3 
…ation

# Conflicts:
#	Packs/CommonScripts/ReleaseNotes/1_7_63.md
@michal-dagan
update ReleaseNotes
a294ab0
@michal-dagan
Merge remote-tracking branch 'origin/master' into MaliciousRatioReput…
bb508c0 
…ation

# Conflicts:
#	Packs/CommonScripts/pack_metadata.json
@michal-dagan
Update currentVersion
d91a208
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/0335e813-1fcc-4077-864e-45d1de771a3f/artifacts/0/artifacts/coverage_report/html/index.html

@yaakovi yaakovi merged commit 6d0e0f3 into master Sep 22, 2022
@yaakovi yaakovi deleted the MaliciousRatioReputation branch September 22, 2022 08:34
This was referenced Sep 22, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bziser bziser bziser approved these changes

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
4 participants
@michal-dagan @xsoar-bot @bziser @yaakovi