Fp set rule 2to3 #21084
Merged
Fp set rule 2to3 #21084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2022 22:41
tkatzir
reviewed
Sep 8, 2022
tkatzir
reviewed
Sep 8, 2022
| @@ -0,0 +1,38 @@ | |||
| import demistomock as demisto # noqa: F401 | |||
| from CommonServerPython import * # noqa: F401 | |||
|
|
|||
There was a problem hiding this comment.
Missing test(s) for mutual exclusion of tritonsystem and remoteaccessname
There was a problem hiding this comment.
Why do we need this? The coverage is 70% it does not need to be 100%.
This test will not find any new issue. the test will use 2 mockers to test 2 lines that were mocked. It will not check any logic!
There was a problem hiding this comment.
Discussed with Dan, and He told me that a unit test for this is not needed.
tkatzir
requested changes
Sep 8, 2022
|
Link to the unit tests coverage report: |
dantavori
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed 2 scripts from py2 to py3 and added scripts.