Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System Diagnostics and Health Check] HealthCheckPlaybookAnalysis script error fix #21865

Merged
merged 1 commit into from Oct 25, 2022

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@ennozdd

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Some variables are defined under an if statement and checked in the global scope. If the statement fails the whole script fails because they are not defined.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

…ipt error fix (#21643)

* fixed not defined error

* moved the values values to the global scope

* added release notes

* modifications because of the comments
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community labels Oct 25, 2022
@moishce moishce merged commit c03ca05 into master Oct 25, 2022
@moishce moishce deleted the contrib/ennozdd_systemdiagnostic branch October 25, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
3 participants