Asm 082922 #21869
Merged
Asm 082922 #21869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding new integration from postman-codegen * additions from UI * changed to the CORE built in Auth * finishing up asm-getassetinternetexposure * finishing command asm-getexternalipaddressrange * finished GetExternalService command * finish asm-getexternalipaddressranges * finish GetExternalServices * work on GetAssetsInternetExposure * finish sm-getassetsinternetexposure * fix to has_active_external_services for getassetsinternetexposure * adding command examples * Removed setup files and first draft of README * descriptions, cleanup, comments, logo * cleanup * Fixed test and params * fix command examples * slimmed down command examples, auto gen README * format * test playbook submission * release notes * added docstring and fixed typo for parameter desc * removed typos * first working unit test * test * fixing mypy lint errors * fixed Flake8 errors on integration * adding more unit tests, fixing typos * first draft of unit tests * more lint/validate * secrets-ignore and redo integration README * removing secrests from test * adding Integration README to pack README * Adding new integration from postman-codegen * additions from UI * changed to the CORE built in Auth * finishing up asm-getassetinternetexposure * finishing command asm-getexternalipaddressrange * finished GetExternalService command * finish asm-getexternalipaddressranges * finish GetExternalServices * work on GetAssetsInternetExposure * finish sm-getassetsinternetexposure * fix to has_active_external_services for getassetsinternetexposure * adding command examples * Removed setup files and first draft of README * descriptions, cleanup, comments, logo * cleanup * Fixed test and params * fix command examples * slimmed down command examples, auto gen README * format * test playbook submission * release notes * added docstring and fixed typo for parameter desc * removed typos * first working unit test * test * fixing mypy lint errors * fixed Flake8 errors on integration * adding more unit tests, fixing typos * first draft of unit tests * more lint/validate * secrets-ignore and redo integration README * removing secrests from test * adding Integration README to pack README * fixing double entry in conf.json * one more fix * adding fromversion to testplaybook * should be 1.1.0 instead of 1.2.0 * changing auth to credential based * updated to use "credential" arg and updated README * uploaded the wrong README (oops) * verifying type of params and params['credentials'] * validate params * removed comment * Apply suggestions from code review Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com> * fix demisto.params type checking Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com> * CortexAttackSurfaceManagement.py add .get to line 147 Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com> * CortexAttackSurfaceManagement.py line 206 .get Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com> * CortexAttackSurfaceManagement.py raw_response is actual raw Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com> * bulk_10_10_22 * fixed issues after bulk_10_10_22 * added insecure and proxy params * change return_error to raise * type hints * command name changes * Fixed the List type hint * Added a call to handle_proxy() * Removed an unused 'args' argument * Revert the removal of the unused 'args' argument * Added the TPB to skipped Tests * Removed unnecessary '-' * Updated the docker image tag * Updated the conf.json * changed all Pub IPs to 1.1.1.1 readme/secre * Update CortexAttackSurfaceManagement_description.md Done. * Update README.md Done. * Update CortexAttackSurfaceManagement.yml Done. * Update 1_1_0.md Done. * Update README.md Done. * Update 1_1_0.md Done. * secret cleanup part 2 * typo * Bulk 10/20/22 * updated per lint error * name changes * fixed test playbook * update docker ver * helped function for standardization * Updated the description file and the readme. * Improved wordings of service_id arg description * Improved the format_asm_id function * added format_asm_id unit test Co-authored-by: Shachar Kidor <82749224+ShacharKidor@users.noreply.github.com> Co-authored-by: ShacharKidor <skidorball@paloaltonetworks.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
content-bot
added
Contribution
ShacharKidor
approved these changes
Oct 25, 2022
|
@ShacharKidor I did not review this PR but I see that you approved the changes and that the docs-approved label was added. Do you still want me to review this? If so, please remove the docs-approved label. |
Hi @ShirleyDenkberg - you did approve the external PR (they are the same). |
|
Link to the unit tests coverage report: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@johnnywilkes
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
relates: EXPANDR-85
Description
Integration to pull Assets information from XSIAM when running in XSIAM. The video does a good job explaining.
Screenshots
Video: https://drive.google.com/file/d/1cTw_6Ujf-WQQv23IXKSJQsjNtWQMVQGE/view?usp=sharing , please let me know who I should add.
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have