Fix bug in RemedyOnDemand.js when running test-module #21888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if test-module ran, then pass `args={}` to fetchIncidents instead of `query=null`
randomizerxd
changed the title
content-bot
changed the base branch from
master
to
contrib/randomizerxd_randomizerxd-RemedyOnDemand-1
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @esharf will know he can start review the proposed changes. |
content-bot
added
Community
Contribution Form Filled
dorschw
requested review from
moishce
and removed request for
esharf and
ilaner
moishce
approved these changes
Nov 16, 2022
moishce
added
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/4046336 |
moishce
merged commit b3a4100
into
demisto:contrib/randomizerxd_randomizerxd-RemedyOnDemand-1
11 tasks
ShahafBenYakir
pushed a commit
that referenced
this pull request
Nov 28, 2022
* Fix bug in RemedyOnDemand.js when running test-module (#21888) * Update RemedyOnDemand.js if test-module ran, then pass `args={}` to fetchIncidents instead of `query=null` * Update pack_metadata.json currentVersion 1.1.1 * Create 1_1_1.md * Update 1_1_1.md Co-authored-by: Randy Baldwin <32545292+randomizerxd@users.noreply.github.com> Co-authored-by: Moshe Galitzky <112559840+moishce@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if test-module ran, then pass
args={}to fetchIncidents instead ofquery=nullContributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Fixes a bug within the RemedyOnDemand integration observed when running test-module
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have