fixed a bug in service now #21955
Merged
fixed a bug in service now #21955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'origin/master' into omer_servicenow_mirroring_bug
Merge remote-tracking branch 'origin/master' into omer_servicenow_mirroring_bug
|
|
||
| @pytest.mark.parametrize('ticket_state, expected_res', [('1', 'Other'), | ||
| ('7', 'Resolved')]) | ||
| def test_converts_state_close_reason(ticket_state, expected_res): |
Co-authored-by: Shahaf Ben Yakir <44666568+ShahafBenYakir@users.noreply.github.com>
Merge remote-tracking branch 'origin/master' into omer_servicenow_mirroring_bug
Merge branch 'omer_servicenow_mirroring_bug' of github.com:demisto/content into omer_servicenow_mirroring_bug
Shellyber
reviewed
Nov 2, 2022
| @@ -6,7 +6,8 @@ | |||
|
|
|||
|
|
|||
| # disable insecure warnings | |||
| requests.packages.urllib3.disable_warnings() | |||
| import urllib3 | |||
| urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning) | |||
There was a problem hiding this comment.
Why did you add the specific exception?
There was a problem hiding this comment.
Let's just change it to:
urllib3.disable_warnings()
Shellyber
reviewed
Nov 2, 2022
Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>
Shellyber
approved these changes
Nov 2, 2022
|
Link to the unit tests coverage report: |
gal-forer
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: link to the issue
Description
There was a bug that closedNotes was in the place of closedReason and the there was no mirror in for the closedReson fixed the 2 issues.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have