Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrowdStrike Falcon - fix cs-falcon-run-script command #21999

Merged
merged 10 commits into from Nov 3, 2022
Merged

Conversation

adi88d
Copy link
Contributor

@adi88d adi88d commented Nov 2, 2022

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

fixed an issue where command cs-falcon-run-script didn't failed if there was STD errors in the response.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@adi88d adi88d marked this pull request as ready for review November 2, 2022 15:55
adi88d and others added 2 commits November 3, 2022 12:34
Co-authored-by: Dan Sterenson <38375556+dansterenson@users.noreply.github.com>
…rikeFalcon.py

Co-authored-by: Dan Sterenson <38375556+dansterenson@users.noreply.github.com>
@xsoar-bot
Copy link
Contributor

@adi88d adi88d merged commit 74e8d8b into master Nov 3, 2022
@adi88d adi88d deleted the fix-CrowdStrike branch November 3, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants