Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration and pack metadatas categories #22317

Merged
merged 30 commits into from Nov 22, 2022
Merged

Fix integration and pack metadatas categories #22317

merged 30 commits into from Nov 22, 2022

Conversation

YuvHayun
Copy link
Contributor

@YuvHayun YuvHayun commented Nov 17, 2022 •
edited

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Fix integration and pack metadatas categories to match the new standards.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

@github-actions
Copy link

Your contributed BitDam pack has been modified on files:

Packs/BitDam/pack_metadata.json
Packs/BitDam/Integrations/BitDam/BitDam.yml
Packs/BitDam/ReleaseNotes/1_0_9.md
Please review the changes here

bakatzir
bakatzir reviewed Nov 17, 2022
View reviewed changes
Copy link
Member

@bakatzir bakatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the category changes made. Letting ENG to approve.

@github-actions
Copy link

Your contributed CyCognito pack has been modified on files:

Packs/CyCognito/pack_metadata.json
Please review the changes here

@github-actions
Copy link

Your contributed CimTrak-SystemIntegrityAssurance pack has been modified on files:

Packs/CimTrak-SystemIntegrityAssurance/ReleaseNotes/1_0_3.md
Packs/CimTrak-SystemIntegrityAssurance/Integrations/CimTrak/CimTrak.yml
Packs/CimTrak-SystemIntegrityAssurance/pack_metadata.json
Please review the changes here

JudahSchwartz
JudahSchwartz approved these changes Nov 20, 2022
View reviewed changes
Copy link
Contributor

@JudahSchwartz JudahSchwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me as long as passes validation. Might be a good idea to split up if we cant get this in in 1 pr

Packs/CyCognito/pack_metadata.json Show resolved Hide resolved
Packs/CaseManagement-Generic/pack_metadata.json Show resolved Hide resolved
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/09d2744f-c290-46c3-b09f-f24022e3ca8c/artifacts/0/artifacts/coverage_report/html/index.html

@YuvHayun YuvHayun merged commit 97bb5f0 into master Nov 22, 2022
@YuvHayun YuvHayun deleted the fix_integration_and_pack_metadatas_categories branch November 22, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakatzir bakatzir bakatzir left review comments

@JudahSchwartz JudahSchwartz JudahSchwartz approved these changes

@michalgold michalgold Awaiting requested review from michalgold

@idovandijk idovandijk Awaiting requested review from idovandijk idovandijk is a code owner

@GuyLibermanPA GuyLibermanPA Awaiting requested review from GuyLibermanPA

@ilaner ilaner Awaiting requested review from ilaner

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
4 participants
@YuvHayun @xsoar-bot @JudahSchwartz @bakatzir