Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug - TAXII2 server missing entries in sdo indicator #23173

Merged
merged 8 commits into from Jan 4, 2023
Merged

Conversation

MLainer1
Copy link
Contributor

@MLainer1 MLainer1 commented Dec 20, 2022

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Missing 2 of the required entries in our sdo indicator
image

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@MLainer1 MLainer1 marked this pull request as ready for review December 20, 2022 16:11
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, waiting for customer's confirmation

@xsoar-bot
Copy link
Contributor

@MLainer1 MLainer1 merged commit 2b45740 into master Jan 4, 2023
@MLainer1 MLainer1 deleted the bug_TAXII2Server branch January 4, 2023 11:27
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
* failed test

* RN and possible fix

* fix test

* DI

* change dir name to test_data

* test data

* test data
ckaadic pushed a commit to ckaadic/content that referenced this pull request Jan 10, 2023
* failed test

* RN and possible fix

* fix test

* DI

* change dir name to test_data

* test data

* test data
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
* failed test

* RN and possible fix

* fix test

* DI

* change dir name to test_data

* test data

* test data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants