Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrowdStrike Falcon X - Fix TPBs #23444

Merged
merged 14 commits into from Jan 3, 2023
Merged

CrowdStrike Falcon X - Fix TPBs #23444

merged 14 commits into from Jan 3, 2023

Conversation

darkushin
Copy link
Contributor

@darkushin darkushin commented Jan 1, 2023 •
edited

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-5019

Description

  • Increased memory threshold.
  • Fixed an issued where the returned response when calling cs-fx-download-ioc was a list.

ostolero
ostolero approved these changes Jan 2, 2023
View reviewed changes
Copy link
Contributor

@ostolero ostolero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! and it seems we actually caught a bug here :) let's make sure tests are picked up and pass in gitlab and we can merge.

@MosheEichler MosheEichler mentioned this pull request Jan 2, 2023
Merged
11 tasks
@darkushin darkushin added the release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process label Jan 2, 2023
@ShirleyDenkberg
Copy link
Contributor

@ostolero Doc review completed.

@ShirleyDenkberg ShirleyDenkberg self-assigned this Jan 3, 2023
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/8734212b-7ae0-4e4a-bbfe-9b74a06db7e1/artifacts/0/artifacts/coverage_report/html/index.html

@darkushin darkushin merged commit 242e40d into master Jan 3, 2023
@darkushin darkushin deleted the cs_fx_tpb branch January 3, 2023 14:03
efelmandar pushed a commit that referenced this pull request Jan 4, 2023
@darkushin @efelmandar
CrowdStrike Falcon X - Fix TPBs (#23444)
cd8326b 
* CrowdStrike Falcon X - Fix TPBs

* Added TPBs to build

* fixed TPBs

* updated memory limit for TPB

* Added RN

* updated docker image

* Added another TPB to the tests
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jan 11, 2023
@darkushin @xsoar-bot
CrowdStrike Falcon X - Fix TPBs (demisto#23444)
cb97563 
* CrowdStrike Falcon X - Fix TPBs

* Added TPBs to build

* fixed TPBs

* updated memory limit for TPB

* Added RN

* updated docker image

* Added another TPB to the tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostolero ostolero ostolero approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved release-notes-only Indicates that this pull request has ONLY release notes to review for documentation process
Projects
None yet
Milestone
No milestone
4 participants
@darkushin @ShirleyDenkberg @xsoar-bot @ostolero