Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbuseIPDB - add support in credential store #23620

Merged
merged 3 commits into from Jan 10, 2023
Merged

AbuseIPDB - add support in credential store #23620

merged 3 commits into from Jan 10, 2023

Conversation

mmhw
Copy link
Contributor

@mmhw mmhw commented Jan 8, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue

Description

Change the type of credentials, from type 4 to type 9.

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@mmhw mmhw requested a review from bziser January 8, 2023 14:03
bziser
bziser approved these changes Jan 8, 2023
View reviewed changes
Packs/AbuseDB/.pack-ignore Outdated Show resolved Hide resolved
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/36b976b2-2ef3-4192-9004-b1ca6fbb5381/artifacts/0/artifacts/coverage_report/html/index.html

@mmhw mmhw self-assigned this Jan 10, 2023
@mmhw mmhw merged commit d1e700e into master Jan 10, 2023
@mmhw mmhw deleted the MW_AbuseDB_add_support_in_credential_store branch January 10, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bziser bziser bziser approved these changes

Assignees

@mmhw mmhw

Labels
docs-approved
Projects
None yet
Milestone
No milestone
3 participants
@mmhw @xsoar-bot @bziser