Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL Regex update to fix IP catching issue and random highlights #23625

Merged
merged 6 commits into from Jan 9, 2023

Conversation

Ni-Knight
Copy link
Contributor

@Ni-Knight Ni-Knight commented Jan 8, 2023

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-19790

Description

Fixed the URL regex to fix an issue with IPs and domains not catching correctly causing highlights in the markdown.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

…ains with invalid TLDs (not strating with a letter) being captured by the regex.
…ains with invalid TLDs (not starting with a letter) being captured by the regex. - RN
@Ni-Knight Ni-Knight merged commit 1e1bc90 into master Jan 9, 2023
@Ni-Knight Ni-Knight deleted the da-highlights-url-regex-fix branch January 9, 2023 14:05
ckaadic pushed a commit to ckaadic/content that referenced this pull request Jan 10, 2023
…sto#23625)

* Updated URL regex to fix a mall issue with IPs as URLs as well as domains with invalid TLDs (not strating with a letter) being captured by the regex.

* Updated URL regex to fix a mall issue with IPs as URLs as well as domains with invalid TLDs (not starting with a letter) being captured by the regex. - RN

* ignore words - TLDs

* Update 3_3_42.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants