Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonScripts last PR #23899

Merged
merged 255 commits into from Jan 31, 2023
Merged

CommonScripts last PR #23899

merged 255 commits into from Jan 31, 2023

Conversation

samuelFain
Copy link
Contributor

@samuelFain samuelFain commented Jan 17, 2023 •
edited by dorschw

No description provided.

@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
48fac0c
@maimorag
updating docker image
8e69a42
@maimorag
updating docker image in hey script
e1701e2
@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
4987d70
@maimorag
added a test to pack hey
e353765
@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
0e434bd
@maimorag
moving packs
3a5bf2b
@maimorag
degrading release note
5f19188
@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
837c5e0
@maimorag
adding ignore to BA114
d14c699
@maimorag
changing release note
f763e29
@maimorag
returning to prev previous state
255636a
@maimorag
moving Content Installation, ExifRead, Fetch Indicators From File, Ge…
89ab236 
…t License ID, Phishing URL to CommonScripts
@maimorag
Empty-Commit
1bc80b5
@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
40486ec
@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
c607f98
@maimorag
adding release note to Hey pack
953c830
@maimorag
Empty-Commit
35235b6
@maimorag
Empty-Commit
7a85abf
@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
8d6b69d
@maimorag
update release note of pack Hey
767f94d
@maimorag
checking if the old docker also fail in exportIndicator
fbcdfc9
@maimorag
adding a release note
d6ed5d6
@maimorag
Merge remote-tracking branch 'origin/master' into moving_to_CommonScr…
adee017 
…ipts_part_two
@maimorag
adding release note of ExifRead
8e0b7a3
@maimorag
docker image
549c985
@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
c0e28b0
@maimorag
deleting Export Indicators Performance Test since the config no longe…
4dd5806 
…r exist
@maimorag
Merge remote-tracking branch 'origin/master' into move_Hey_to_Dev_Tools
b540820
@maimorag
Empty-Commit
e88fb7b
@daryakoval
Copy link
Contributor

Hi, Please make sure that there are no leftovers from my debugging.

After a lot of debugging, we have a bug that won't fix, because we led to some irrational installation of packs that caused this bug.
We decided to do some architectural changes to solve the issue. It will take some time to solve it.

Please remove from this pr the scripts that use rasterize and Whois. (The scripts that caused CommonScripts to be dependent on rasterize and Whois), and move them to another PR that will be blocked.
Check if the original PR's build passes without the scripts I asked to remove.
Update me if any assistance is needed.

Shellyber
Shellyber reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflicts as well

Packs/CommonScripts/ReleaseNotes/1_11_13.md Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/GetLicenseID/README.md Outdated Show resolved Hide resolved
Packs/CommonScripts/pack_metadata.json Outdated Show resolved Hide resolved
Shellyber
Shellyber reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maimorag @samuelFain See my notes

Packs/CommonScripts/.pack-ignore Outdated Show resolved Hide resolved
Packs/CommonScripts/ReleaseNotes/1_11_14.md Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/FetchIndicatorsFromFile/FetchIndicatorsFromFile.py Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/FetchIndicatorsFromFile/FetchIndicatorsFromFile.py Outdated Show resolved Hide resolved
Packs/CommonScripts/Scripts/ParseYAML/ParseYAML.py Outdated Show resolved Hide resolved
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/a48e23cc-dd45-459b-8674-97d30d518146/artifacts/0/artifacts/coverage_report/html/index.html

@DeanArbel DeanArbel merged commit dccfd2a into master Jan 31, 2023
@DeanArbel DeanArbel deleted the commonscripts-last-pr branch January 31, 2023 14:44
ostolero pushed a commit that referenced this pull request Feb 1, 2023
@samuelFain @ostolero
CommonScripts last PR (#23899)
98c2ca2
@samuelFain samuelFain mentioned this pull request Feb 3, 2023
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maimorag maimorag maimorag left review comments

@Shellyber Shellyber Shellyber approved these changes

@dorschw dorschw Awaiting requested review from dorschw

@daryakoval daryakoval Awaiting requested review from daryakoval

@yaakovpraisler yaakovpraisler Awaiting requested review from yaakovpraisler

Assignees

@samuelFain samuelFain

@maimorag maimorag

Labels
docs-approved ForceMerge
Projects
None yet
Milestone
No milestone