Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rasterize html wait time #24173

Merged
merged 10 commits into from Jan 31, 2023
Merged

Rasterize html wait time #24173

merged 10 commits into from Jan 31, 2023

Conversation

tomer-pan
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-5474

Description

In order to analyze html files which redirect to other sites, the "wait_time" argument should be available in the rasterize-html command.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

@xsoar-bot
Copy link
Contributor

Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, see comment

Copy link
Contributor

@idovandijk idovandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@tomer-pan tomer-pan merged commit 34aabc2 into master Jan 31, 2023
@tomer-pan tomer-pan deleted the rasterize_html_wait_time branch January 31, 2023 09:04
ostolero pushed a commit that referenced this pull request Feb 1, 2023
* Add wait_time to rasterize-html

* Add wait_time to rasterize-html

* indentation

* RN

* RN

* update docker and indentations

* coverage fix

* Add simple.html

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants