Xsoar mirroring bug #24233
Merged
Xsoar mirroring bug #24233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Packs/XSOARmirroring/Integrations/XSOARmirroring/README.md
yuvalbenshalom
requested changes
Feb 1, 2023
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.yml
Outdated
Show resolved
Hide resolved
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.yml
Outdated
Show resolved
Hide resolved
dorschw
reviewed
Feb 1, 2023
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.py
Outdated
Show resolved
Hide resolved
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.py
Outdated
Show resolved
Hide resolved
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.yml
Outdated
Show resolved
Hide resolved
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.yml
Outdated
Show resolved
Hide resolved
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring_test.py
Outdated
Show resolved
Hide resolved
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring_test.py
Outdated
Show resolved
Hide resolved
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring_test.py
Outdated
Show resolved
Hide resolved
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.py
Outdated
Show resolved
Hide resolved
dorschw
reviewed
Feb 1, 2023
dorschw
reviewed
Feb 1, 2023
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.py
Outdated
Show resolved
Hide resolved
dorschw
reviewed
Feb 1, 2023
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.py
Outdated
Show resolved
Hide resolved
…g.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
…g.py Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
dorschw
approved these changes
Feb 1, 2023
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring_test.py
Outdated
Show resolved
Hide resolved
dorschw
reviewed
Feb 1, 2023
Packs/XSOARmirroring/Integrations/XSOARmirroring/XSOARmirroring.py
Outdated
Show resolved
Hide resolved
dorschw
reviewed
Feb 1, 2023
dorschw
reviewed
Feb 1, 2023
dorschw
reviewed
Feb 1, 2023
|
Link to the unit tests coverage report: |
yuvalbenshalom
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/XSUP-20748
Description
Added a parameter 'Mirror Playbook ID' which allows to choose if mirroring the playbookId or not.
With this fix, the custom playbook on the remote side will not be transferred, so it will run according to the incident type's default playbook on the other side.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have