Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPQualityScore Encoding and Results Bug Fixes #24701

Conversation

IPQSDemisto
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

N/A

Description

Bug fixes for two issues:

  • The URL lookup functionality currently doesn't pull the correct value. It should pull risk_score instead of fraud_score.
  • The Email lookup functionality did not URL encode all emails. This could lead to malformed results. The Email lookup functionality now encodes all emails.

Screenshots

N/A

Minimum version of Cortex XSOAR

  • [ x ] 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • [ x ] No

Must have

  • Tests
  • Documentation

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Feb 18, 2023
@content-bot content-bot changed the base branch from master to contrib/IPQSDemisto_IPQualityScore February 18, 2023 03:07
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @adi88d will know he can start review the proposed changes.

@gal-forer gal-forer requested review from daryakoval and removed request for adi88d February 19, 2023 08:52
@gal-forer gal-forer assigned daryakoval and unassigned adi88d Feb 19, 2023
Copy link
Contributor

@daryakoval daryakoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IPQSDemisto Hi,

  1. Make sure to register your contribution by filling out the contribution registration form at https://forms.gle/XDfxU4E61ZwEESSMA
  2. please add release notes and bump pack version.
  3. please fix test_email_command that fails after your changes.
  4. The docker image tag is not the latest numeric tag, please update it to: 3.10.10.48392

@daryakoval
Copy link
Contributor

@IPQSDemisto Hi, please address the notes I added here.

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2023

CLA assistant check
All committers have signed the CLA.

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Mar 5, 2023
@IPQSDemisto
Copy link
Contributor Author

IPQSDemisto commented Mar 5, 2023

@daryakoval

  1. Done.
  2. Done.
  3. Done.
  4. Done.

@daryakoval daryakoval merged commit d716a4c into demisto:contrib/IPQSDemisto_IPQualityScore Mar 6, 2023
daryakoval pushed a commit that referenced this pull request Mar 6, 2023
* Fix bug with URL risk scoring.

* Fix URL encoding for emails.

* Version upgrade.

* Version.

* Release notes.

* Update docker image version.

* Fix URL Lib 3 import.

* Fix bugs with test_email_command.

* Test.

* Undo.

---------

Co-authored-by: IPQSDemisto <80794987+IPQSDemisto@users.noreply.github.com>
Co-authored-by: IPQualityScore LLC <support@ipqualityscore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Partner
Projects
None yet
7 participants