[CIAC-5684] Deprecate old py2 content entities #24765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShacharKidor
suggested changes
Feb 21, 2023
There was a problem hiding this comment.
Nice :)
@samuelFain - I've added a few little comments please review.
Also - I think it is worth adding a word about the deprecation to the README files of each deprecated item.
| @@ -29,12 +29,12 @@ configuration: | |||
| name: proxy | |||
| required: false | |||
| type: 8 | |||
| description: Sandbox Cloud | |||
| display: Joe Security | |||
| description: Deprecated. No available replacement. | |||
There was a problem hiding this comment.
Isn't Joe Security v2 the available replacement for that integration?
There was a problem hiding this comment.
You are correct, fixed it 👍
|
|
||
| ##### Joe Security (Deprecated) | ||
|
|
||
| - Deprecated. Use Joe Security v2 instead. |
There was a problem hiding this comment.
Suggested change
| - Deprecated. Use Joe Security v2 instead. | |
| - Deprecated. Use **Joe Security v2** instead. |
| @@ -0,0 +1,15 @@ | |||
|
|
|||
| #### Scripts | |||
|
|
|||
There was a problem hiding this comment.
Please use RN entity styling in this RN file as well - Entity Styiling.
|
Link to the unit tests coverage report: |
ShacharKidor
approved these changes
Feb 22, 2023
samuelFain
deleted the
feature/CIAC-5684/deprecate-old-py2-content-entities
branch
ayman-m
pushed a commit
to my-soar/content
that referenced
this pull request
Feb 24, 2023
* Deprecate JoeSecurity V1 Integration * Deprecate SbDownload script from Sandblast Pack * Deprecate SbQuery script from Sandblast Pack * Deprecate SbQuota script from Sandblast Pack * Deprecate SbUpload script from Sandblast Pack * Updated JoeSecurity and Sandblast packs RN * pre-commit "No newline at end of file" fix * Joe Security V1 integration RN fix * Updated RN * Update Joe Security README.md * Revert deprecated comment in content items README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-5684
Description
The following content entities have a v2 and are in py2, they are deprecated in this PR:
JoeSecurity Pack:
Joe Security
Sandblast Pack:
SbDownload
SbQuery
SbQuota
SbUpload
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have