Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS-AccessAnalyzer GA #24834

Merged
merged 12 commits into from Feb 28, 2023
Merged

AWS-AccessAnalyzer GA #24834

merged 12 commits into from Feb 28, 2023

Conversation

ilappe
Copy link
Contributor

@ilappe ilappe commented Feb 22, 2023

Related Issues

fixes: https://jira-hq.paloaltonetworks.local/browse/CIAC-2121

Description

Moved AWS-AccessAnalyzer from Beta to GA

Does it break backward compatibility?

  • Yes
    • some context path was changed from the beta version

Must have

  • Tests
  • Documentation

@ilappe ilappe self-assigned this Feb 22, 2023
DeanArbel
DeanArbel approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work

@ShirleyDenkberg
Copy link
Contributor

@ilappe Please review my comments in the yml and then regenerate the readme.
@DeanArbel Doc review completed.

ilappe and others added 2 commits February 28, 2023 14:01
@ilappe @ShirleyDenkberg
Apply suggestions from code review
9b30688 
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@ilappe
CR changes
5a52fb9
@xsoar-bot
Copy link
Contributor

Link to the unit tests coverage report:
https://output.circle-artifacts.com/output/job/57b4c5e8-7c64-47f1-acac-0e0ca5fe17d9/artifacts/0/artifacts/coverage_report/html/index.html

@DeanArbel DeanArbel merged commit 4df786e into master Feb 28, 2023
@DeanArbel DeanArbel deleted the aws_access_analyzer_GA branch February 28, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@DeanArbel DeanArbel DeanArbel approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

@ilappe ilappe

Labels
docs-approved ForceMerge
Projects
None yet
Milestone
No milestone
4 participants
@ilappe @ShirleyDenkberg @xsoar-bot @DeanArbel