Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

McAfee MAR - delete files #24879

Merged
merged 9 commits into from Feb 28, 2023
Merged

McAfee MAR - delete files #24879

merged 9 commits into from Feb 28, 2023

Conversation

RotemAmit
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Added the deletion of the files at the end of their use.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Packs/McAfee-MAR/Integrations/McAfee-MAR/McAfee-MAR.py Outdated Show resolved Hide resolved
Packs/McAfee-MAR/ReleaseNotes/1_0_5.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Shellyber Shellyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the creation of the cert files under the try also

@xsoar-bot
Copy link
Contributor

text_file.write(demisto.params()['broker_ca_bundle'])

with open(cert_file, "w") as text_file:
text_file.write(demisto.params()['cert_file']) # lgtm [py/clear-text-storage-sensitive-data]

Check failure

Code scanning / CodeQL

Clear-text storage of sensitive information

This expression stores [sensitive data (certificate)](1) as clear text.
@RotemAmit RotemAmit merged commit 340eca6 into master Feb 28, 2023
@RotemAmit RotemAmit deleted the McAfee_UpdateFiles branch February 28, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants