Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PrismaCloudV2] - Add In and Out Mirroring #25335

Merged

Conversation

ShacharKidor
Copy link
Contributor

@ShacharKidor ShacharKidor commented Mar 16, 2023

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-5504.

Description

Implementation of the mirror in and out for Prisma Cloud v2 integration, as described in this issue - CIAC-5504.

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@xsoar-bot
Copy link
Contributor

ShacharKidor and others added 18 commits August 15, 2023 22:18
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
@ShacharKidor ShacharKidor merged commit 5f21632 into master Aug 21, 2023
14 checks passed
@ShacharKidor ShacharKidor deleted the Enhancement/CIAC-5504/Add-mirroring-to-PrismaCloudV2 branch August 21, 2023 12:40
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
* Initial commit

* Added default mirroring fields to the mapper

* Added initial version of get-modified-remote-data command

* Added dismissal Note field to the mapper

* Added mirroring fields to the fetch incidents command

* Added initial version for get_remote_data_command

* Added 'get-remote-data' command

* Update TODOs

* Revert unnecessary changes

* Removed dismissal note field from mapper

* Improved mapper

* debugging

* - Fixed Mirror In
- Added Prisma Cloud Dismissal Note as a readonly Field

* Added dismissal note field to the layout

* Fixed the Reopen alert mirrorIn

* Added docstrings to mirroring functions

* Mirror In Improvements

* Added docstrings to mirror In functions

* Added initial version of mirror out

* Improved mirror out

* Make Prisma Cloud Status Field Readonly

* Added returned value typing

* Fixed typing

* Added docstring to mirror out functions

* Removed the return of the response - error handling happen in the self.http_request

* Added missing ':'

* Changed filters for mirroring

* Mirroring improvements - In and Out works as expected.

* Removed the get-mapping-fields command

* docstring updates

* Mirror out final improvements

* Improved logs and docstrings

* Added mirroring info the the README.md

* Added RN

* - Updated the docker image
- Ran format on the dismissal note field

* Fixed Unit Tests + Pre commit Fixes

* hooks fixes

* removed dismissal note from close form

* Added the dismissal Note field to all relevant layouts

* Added the 'reason' field to the mirror In

* Changed Prisma Cloud Reason incident field to Read Only

* Readme Improvements

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/PrismaCloudV2.py

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/PrismaCloudV2.py

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/PrismaCloudV2.py

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>

* - Updated the RN file
- Updated the docker image

* Added 'Prioritization' to the known words

* Fixed the RN file

* Fixed the RN file

* Added closing time field to the mirror in

* Removed mirror_direction and mirror_instance constants

* Added the policy.name field to the mirrored fields (content workaround)

* Call close_alert and close_incident params from the client

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/PrismaCloudV2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/PrismaCloudV2.yml

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/Integrations/PrismaCloudV2/README.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Fixed README.md

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Update Packs/PrismaCloud/ReleaseNotes/4_2_0.md

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

* Fixed UTs and Mypy errors

* Fixed Unit Tests

* Fixed Mypy Error

* Added default values

* Added mirror in unit tests

* Added mirror out unit tests

* Removing the ismappable key from the yml

* Pre-commit fixes

---------

Co-authored-by: yuvalbenshalom <ybenshalom@paloaltonetworks.com>
Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants