[Marketplace Contribution] Akamai WAF - Content Pack Update #25457

xsoar-bot · 2023-03-22T14:26:03Z

Status

In Progress
Ready
In Hold - (Reason for hold)

Contributor

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

content-bot · 2023-03-22T14:27:59Z

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @daryakoval will very shortly look over your proposed changes.

…into davistonehub-contrib-Akamai_WAF

Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py

Packs/Akamai_WAF/ReleaseNotes/2_1_0.md

gal-forer · 2023-03-25T21:17:08Z

@davistonehub Hi, thank you for the contribution, I would love for us to have a demo for the new commands, please let me know when you're available ? You can reach me at gforer@paloaltonetworks.com and I'm also on DFIR

gal-forer · 2023-03-25T21:32:57Z

@davistonehub And also because this is an XSOAR supported integration you'll have to add unit tests to the new commands

ShirleyDenkberg · 2023-03-26T07:52:01Z

Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

      name: change_path
      required: true
    description: acknowledge pre verification warning
    name: akamai-acknowledge-pre-verification-warning
-  dockerimage: demisto/akamai:1.0.0.48112
+  - arguments:
+    - description: Unique identifier for the contract


Suggested change

- description: Unique identifier for the contract

- description: Unique identifier for the contract.

ShirleyDenkberg · 2023-03-26T07:53:38Z

Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

+      required: true
+    - description: name of the papi property
+      name: property_name
+    - description: Unique identifier for the group


Suggested change

- description: Unique identifier for the group

- description: Unique identifier for the group.

Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

ShirleyDenkberg · 2023-03-26T08:38:47Z

Packs/Akamai_WAF/ReleaseNotes/2_1_0.md

+- Updated the function "list_papi_property_bygroup_ec" to return more context values.
+- Updated the command "get_appsec_config_latest_version_command" to return an error if the security configuration with the name provided is not found.
+- Added a new command "list_papi_property_bygroup_command": Lists properties available for the current contract and group.
+- Added a new command "get_papi_property_byname_command": Get papi property info without default rule. To get default rule, please use "get-papi-property-rule" command.


Delete the lines below since I added them as second level bullets in the previous comment. It's just easier to read that way.

Removed as per suggestion.

ShirleyDenkberg · 2023-03-26T08:39:31Z

@gal-forer Doc review completed.

Co-authored-by: gal-forer <forer.gal@gmail.com>

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Removed two comment lines 5040/5041 as per suggestion.

Remove line 6,9,10,11,12 as per suggestion

Change command name from "akami-list-papi-property-bygroup" to "akami-list-papi-property-by-group". Change command name from "akami-get-papi-property-byname" to "akami-get-papi-property-by-name". Change command name from "akami-get-papi-property-byid" to "akami-get-papi-property-by-id".

Changed the name of the command from "list_papi_property_bygroup_command" to "list_papi_property_by_group_command". Changed the name of the command from "get_papi_property_byname_command" to "get_papi_property_by_name_command". Changed the name of the command from "get_papi_property_byid_command" to " get_papi_property_by_id_command". Corrected the variable "entry_context" assignment in command "list_papi_property_by_group_command". Allowed the non-case-sensitive comparison in command "clone_security_policy_command" by adding ".lower()" function.

…into davistonehub-contrib-Akamai_WAF

replace "proerty" with "property"

Fixed indents.

Changed line "list papi property bygroup command" to "list papi property by group command". Changed line "get papi property byname command" to "get papi property by name command". Changed line "get papi property byid command" to "get papi property by id command".

content-bot · 2023-04-01T02:39:23Z

For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/4946372

github-advanced-security · 2023-04-01T02:42:00Z

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found 10 existing alerts. Please check the repository Security tab to see all alerts.

github-advanced-security · 2023-04-01T03:00:59Z

You have successfully added a new CodeQL configuration /language:python. As part of the setup process, we have scanned this repository and found 78 existing alerts. Please check the repository Security tab to see all alerts.

* [Marketplace Contribution] Akamai WAF - Content Pack Update (#25457) * "contribution update to pack "Akamai WAF"" * Update 2_1_0.md * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: gal-forer <forer.gal@gmail.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: gal-forer <forer.gal@gmail.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py Co-authored-by: gal-forer <forer.gal@gmail.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Update Akamai_WAF.py Removed two comment lines 5040/5041 as per suggestion. * Update 2_1_0.md Remove line 6,9,10,11,12 as per suggestion * Update Akamai_WAF.yml Change command name from "akami-list-papi-property-bygroup" to "akami-list-papi-property-by-group". Change command name from "akami-get-papi-property-byname" to "akami-get-papi-property-by-name". Change command name from "akami-get-papi-property-byid" to "akami-get-papi-property-by-id". * Update Akamai_WAF.py Changed the name of the command from "list_papi_property_bygroup_command" to "list_papi_property_by_group_command". Changed the name of the command from "get_papi_property_byname_command" to "get_papi_property_by_name_command". Changed the name of the command from "get_papi_property_byid_command" to " get_papi_property_by_id_command". Corrected the variable "entry_context" assignment in command "list_papi_property_by_group_command". Allowed the non-case-sensitive comparison in command "clone_security_policy_command" by adding ".lower()" function. * Update Akamai_WAF.py replace "proerty" with "property" * Update Akamai_WAF.py Fixed indents. * Update Akamai_WAF.py Changed line "list papi property bygroup command" to "list papi property by group command". Changed line "get papi property byname command" to "get papi property by name command". Changed line "get papi property byid command" to "get papi property by id command". --------- Co-authored-by: davistonehub <111578758+davistonehub@users.noreply.github.com> Co-authored-by: gal-forer <forer.gal@gmail.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> * Regenerated readme * Regenerated readme --------- Co-authored-by: xsoar-bot <67315154+xsoar-bot@users.noreply.github.com> Co-authored-by: davistonehub <111578758+davistonehub@users.noreply.github.com> Co-authored-by: gal-forer <forer.gal@gmail.com> Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com> Co-authored-by: gal-forer <gforer@paloaltonetworks.com>

"contribution update to pack "Akamai WAF""

951b5f6

content-bot added the Contribution Thank you! Contributions are always welcome! label Mar 22, 2023

content-bot changed the base branch from master to contrib/xsoar-contrib_davistonehub-contrib-Akamai_WAF March 22, 2023 14:27

content-bot assigned daryakoval Mar 22, 2023

content-bot requested a review from daryakoval March 22, 2023 14:27

daryakoval requested review from yucohen and removed request for daryakoval March 22, 2023 15:17

daryakoval assigned yucohen and unassigned daryakoval Mar 22, 2023

davistonehub added 2 commits March 22, 2023 11:36

Update 2_1_0.md

f111e9f

Merge branch 'contrib/xsoar-contrib_davistonehub-contrib-Akamai_WAF' …

6b45326

…into davistonehub-contrib-Akamai_WAF

gal-forer requested review from gal-forer and removed request for yucohen March 22, 2023 18:43

gal-forer assigned gal-forer and unassigned yucohen Mar 22, 2023

gal-forer suggested changes Mar 25, 2023

View reviewed changes

gal-forer assigned ShirleyDenkberg Mar 25, 2023

gal-forer added the pending-contributor The PR is pending the response of its creator label Mar 25, 2023

ShirleyDenkberg reviewed Mar 26, 2023

View reviewed changes

ShirleyDenkberg added the docs-approved label Mar 26, 2023

davistonehub mentioned this pull request Mar 27, 2023

[Marketplace Contribution] Akamai WAF #25409

Closed

4 tasks

davistonehub and others added 5 commits March 28, 2023 13:21

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py

4903266

Co-authored-by: gal-forer <forer.gal@gmail.com>

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py

a734de1

Co-authored-by: gal-forer <forer.gal@gmail.com>

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.py

650e9f0

Co-authored-by: gal-forer <forer.gal@gmail.com>

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

a5d489a

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

42b8fd4

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

davistonehub and others added 13 commits March 28, 2023 13:23

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

78a6cf6

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

5f55784

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

3591032

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

491b5dd

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Packs/Akamai_WAF/Integrations/Akamai_WAF/Akamai_WAF.yml

7951837

Co-authored-by: ShirleyDenkberg <62508050+ShirleyDenkberg@users.noreply.github.com>

Update Akamai_WAF.py

484498b

Removed two comment lines 5040/5041 as per suggestion.

Update 2_1_0.md

86d6bc6

Remove line 6,9,10,11,12 as per suggestion

Merge branch 'contrib/xsoar-contrib_davistonehub-contrib-Akamai_WAF' …

c15618d

…into davistonehub-contrib-Akamai_WAF

Update Akamai_WAF.py

fad2e9b

replace "proerty" with "property"

Update Akamai_WAF.py

b10016d

Fixed indents.

Update Akamai_WAF.py

9238e94

Changed line "list papi property bygroup command" to "list papi property by group command". Changed line "get papi property byname command" to "get papi property by name command". Changed line "get papi property byid command" to "get papi property by id command".

gal-forer added ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. post-demo labels Apr 1, 2023

gal-forer approved these changes Apr 4, 2023

View reviewed changes

gal-forer merged commit c743bcc into demisto:contrib/xsoar-contrib_davistonehub-contrib-Akamai_WAF Apr 4, 2023
18 of 21 checks passed

content-bot mentioned this pull request Apr 4, 2023

[Marketplace Contribution] Akamai WAF - Content Pack Update #25735

Merged

3 tasks

xsoar-bot deleted the davistonehub-contrib-Akamai_WAF branch November 23, 2023 16:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Marketplace Contribution] Akamai WAF - Content Pack Update #25457

[Marketplace Contribution] Akamai WAF - Content Pack Update #25457

xsoar-bot commented Mar 22, 2023

content-bot commented Mar 22, 2023

gal-forer commented Mar 25, 2023

gal-forer commented Mar 25, 2023

ShirleyDenkberg Mar 26, 2023

ShirleyDenkberg Mar 26, 2023

ShirleyDenkberg Mar 26, 2023

davistonehub Mar 28, 2023

ShirleyDenkberg commented Mar 26, 2023

content-bot commented Apr 1, 2023 •

edited

github-advanced-security bot commented Apr 1, 2023

github-advanced-security bot commented Apr 1, 2023

	- description: Unique identifier for the contract
	- description: Unique identifier for the contract.

[Marketplace Contribution] Akamai WAF - Content Pack Update #25457

[Marketplace Contribution] Akamai WAF - Content Pack Update #25457

Conversation

xsoar-bot commented Mar 22, 2023

Status

Contributor

Video Link

content-bot commented Mar 22, 2023

gal-forer commented Mar 25, 2023

gal-forer commented Mar 25, 2023

ShirleyDenkberg Mar 26, 2023

Choose a reason for hiding this comment

ShirleyDenkberg Mar 26, 2023

Choose a reason for hiding this comment

ShirleyDenkberg Mar 26, 2023

Choose a reason for hiding this comment

davistonehub Mar 28, 2023

Choose a reason for hiding this comment

ShirleyDenkberg commented Mar 26, 2023

content-bot commented Apr 1, 2023 • edited

github-advanced-security bot commented Apr 1, 2023

github-advanced-security bot commented Apr 1, 2023

content-bot commented Apr 1, 2023 •

edited