Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error message for locked reports #25629

Merged
merged 7 commits into from Apr 2, 2023
Merged

Add error message for locked reports #25629

merged 7 commits into from Apr 2, 2023

Conversation

jthom-vmray
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

For one of VMRay's products - FinalVerdict - the customers will not have access to reports that are downloaded by 'vmray-get-summary' command. We added an descriptive error message for that case.

Screenshots

Paste here any images that will help the reviewer

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.5.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Tests
  • Documentation

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Mar 30, 2023
@content-bot content-bot changed the base branch from master to contrib/jthom-vmray_add-error-message-for-locked-reports March 30, 2023 13:55
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yucohen will know the proposed changes are ready to be reviewed.

@content-bot content-bot added Contribution Form Filled Whether contribution form filled or not. Partner labels Mar 30, 2023
yucohen
yucohen reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@yucohen yucohen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jthom-vmray Thanks for the contribution! great work! Only one change - update the docker image so validations wont fail

.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found 10 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:python. As part of the setup process, we have scanned this repository and found 78 existing alerts. Please check the repository Security tab to see all alerts.

@jthom-vmray
Copy link
Contributor Author

jthom-vmray commented Mar 31, 2023 •
edited

Is there something I can do about the image creation error?

@kgal-pan
Copy link
Contributor

kgal-pan commented Apr 2, 2023 •
edited

Is there something I can do about the image creation error?

We're looking into this. Seems to be an issue across in other PRs as well. We'll update when it's resolved.

Update
Likely related to demisto/dockerfiles#13940

@yucohen
Copy link
Contributor

yucohen commented Apr 2, 2023

@kgal-pan @jthom-vmray merging to internal

@yucohen yucohen merged commit 46a6d64 into demisto:contrib/jthom-vmray_add-error-message-for-locked-reports Apr 2, 2023
18 of 19 checks passed
@content-bot content-bot mentioned this pull request Apr 2, 2023
Merged
11 tasks
yucohen added a commit that referenced this pull request Apr 3, 2023
@content-bot @jthom-vmray @yucohen
Add error message for locked reports (#25629) (#25685)
a22b867 
* Update .devcontainer.json name

* add error message for locked reports

* revert poerty version

* update docker image tag

---------

Co-authored-by: Jens Thom <72789379+jthom-vmray@users.noreply.github.com>
Co-authored-by: jthom-vmray <jthom-vmray@users.noreply.github.com>
Co-authored-by: yucohen <86777474+yucohen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yucohen yucohen yucohen approved these changes

@ilaner ilaner Awaiting requested review from ilaner

Assignees

@kgal-pan kgal-pan

@yucohen yucohen

Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Partner
Projects
None yet
Milestone
No milestone
4 participants
@jthom-vmray @content-bot @kgal-pan @yucohen