New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Marketplace Contribution] Carbon Black Enterprise Protection - Content Pack Update #25638
Conversation
Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @dansterenson will very shortly look over your proposed changes. |
Submission release notes got dropped, added back.
You have successfully added a new CodeQL configuration |
You have successfully added a new CodeQL configuration |
Spelling correction.
Fixed "spelling" error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, see my minor notes (I will approve once they are resolved).
I am assuming the change was tested already, right? API reference for v8.1 is not available online...
sectionOrder: | ||
- Connect | ||
- Collect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check why this was removed during the contribution process but it shouldn't. Let me know if you need me to revert this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure why those got dropped either. I've added a commit adding those back.
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Added sectionOrder back in the config since was dropped during contribution.
It has been tested as our console is at version 8.1 and suffering a bug that required this workaround. |
…t' into landonc-contrib-CarbonBlackProtect
8d6acd6
into
demisto:contrib/xsoar-contrib_landonc-contrib-CarbonBlackProtect
Status
Contributor
@landonc
Notes
Some extra updates that will be seen are to clean up validation errors that already existed in the pack such as removing extra lines, adding more space before comment, etc.
Video Link
Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.