Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Marketplace Contribution] Carbon Black Enterprise Protection - Content Pack Update #25638

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@landonc

Notes

Some extra updates that will be seen are to clean up validation errors that already existed in the pack such as removing extra lines, adding more space before comment, etc.

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added the Contribution Thank you! Contributions are always welcome! label Mar 30, 2023
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_landonc-contrib-CarbonBlackProtect March 30, 2023 16:08
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @dansterenson will very shortly look over your proposed changes.

Submission release notes got dropped, added back.
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:javascript. As part of the setup process, we have scanned this repository and found 10 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration /language:python. As part of the setup process, we have scanned this repository and found 78 existing alerts. Please check the repository Security tab to see all alerts.

Spelling correction.
@dansterenson dansterenson removed their request for review March 31, 2023 06:27
@dansterenson dansterenson removed their assignment Mar 31, 2023
Fixed "spelling" error.
@gal-forer gal-forer assigned dantavori and unassigned gal-forer Apr 1, 2023
@gal-forer gal-forer removed their request for review April 1, 2023 02:19
Copy link
Contributor

@dantavori dantavori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see my minor notes (I will approve once they are resolved).
I am assuming the change was tested already, right? API reference for v8.1 is not available online...

Packs/CarbonBlackProtect/ReleaseNotes/1_0_33.md Outdated Show resolved Hide resolved
Comment on lines 2 to 4
sectionOrder:
- Connect
- Collect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check why this was removed during the contribution process but it shouldn't. Let me know if you need me to revert this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why those got dropped either. I've added a commit adding those back.

landonc and others added 2 commits April 3, 2023 09:09
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Added sectionOrder back in the config since was dropped during contribution.
@landonc
Copy link
Contributor

landonc commented Apr 3, 2023

Looks good, see my minor notes (I will approve once they are resolved). I am assuming the change was tested already, right? API reference for v8.1 is not available online...

It has been tested as our console is at version 8.1 and suffering a bug that required this workaround.

@dantavori dantavori merged commit 8d6acd6 into demisto:contrib/xsoar-contrib_landonc-contrib-CarbonBlackProtect Apr 3, 2023
19 checks passed
dantavori pushed a commit that referenced this pull request Apr 3, 2023
@xsoar-bot xsoar-bot deleted the landonc-contrib-CarbonBlackProtect branch November 23, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Thank you! Contributions are always welcome! docs-approved
Projects
None yet
6 participants