Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the Reporter Email Address field from Phishing to CommonTypes pack #25683

Merged
merged 6 commits into from Apr 3, 2023

Conversation

idovandijk
Copy link
Contributor

@idovandijk idovandijk commented Apr 2, 2023

Status

Ready

Related Issues

Moving the field because of https://jira-hq.paloaltonetworks.local/browse/CIAC-4697

Description

Moved the Reporter Email Address field from the Phishing pack to the CommonTypes pack.
This is needed because the field needs to be used in an upcoming pack, and Phishing is no longer a core pack.

Does it break backward compatibility?

Yes, but not really because CommonTypes is a Core pack

@idovandijk
Copy link
Contributor Author

@dantavori Could you please force merge this PR?
The reason force merge is needed is because I moved a field from Phishing to CommonTypes. The purpose of this is to use the field in an upcoming pack without creating a dependency on Phishing.

@dantavori dantavori merged commit 124cc44 into master Apr 3, 2023
18 of 19 checks passed
@dantavori dantavori deleted the move-reporteremailaddress-to-common branch April 3, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants