Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ciac-2676/detonate url generic enhancments #25787

Merged
merged 117 commits into from Jul 17, 2023
Merged

Ciac-2676/detonate url generic enhancments #25787

merged 117 commits into from Jul 17, 2023

Conversation

efelmandar
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

As some integrations such as Wildfire have been updated to have a builtin polling mechanism we can simplify the process of detonation to a single task or smaller playbook that doesn't require the use of generic polling
This PR introduces these new detonate URL playbooks, not a new V but that use fromversion for 6.8 and that will support polling commands

Minimum version of Cortex XSOAR

  • 6.0.0
  • 6.1.0
  • 6.2.0
  • 6.8.0

Does it break backward compatibility?

  • Yes
    • Further details:
  • No

Must have

  • Documentation

@efelmandar efelmandar changed the title Ciac 2676/detonate url generic enhancments Ciac-2676/detonate url generic enhancments Apr 10, 2023
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Palo_Alto_Networks_WildFire pack version was bumped to 2.1.21.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@efelmandar efelmandar marked this pull request as ready for review April 13, 2023 15:26
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Phishing pack version was bumped to 3.5.24.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

OmriItzhak
OmriItzhak reviewed Jul 13, 2023
View reviewed changes
Packs/CommonPlaybooks/ReleaseNotes/2_3_79.md Outdated Show resolved Hide resolved
Packs/JoeSecurity/Playbooks/playbook-Detonate_URL_-_JoeSecurity_5_0_README.md Outdated Show resolved Hide resolved
Packs/JoeSecurity/Playbooks/playbook-Detonate_URL_-_JoeSecurity_README.md Outdated Show resolved Hide resolved
Packs/JoeSecurity/Playbooks/playbook-Detonate_URL_-_JoeSecurity_5_0.yml Outdated Show resolved Hide resolved
Packs/CommonPlaybooks/Playbooks/playbook-Detonate_URL_-_Generic_v1.5.yml Show resolved Hide resolved
Packs/CommonPlaybooks/Playbooks/playbook-Detonate_URL_-_Generic_v1.5.yml Outdated Show resolved Hide resolved
Packs/CommonPlaybooks/Playbooks/playbook-Detonate_URL_-_Generic_v1.5.yml Show resolved Hide resolved
Packs/CommonPlaybooks/Playbooks/playbook-Detonate_URL_-_Generic_v1.5.yml Show resolved Hide resolved
Packs/Phishing/ReleaseNotes/3_5_24.md Show resolved Hide resolved
@efelmandar efelmandar removed the request for review from ilaner July 17, 2023 12:45
@efelmandar efelmandar merged commit cba3b28 into master Jul 17, 2023
13 of 14 checks passed
@efelmandar efelmandar deleted the ciac-2676/detonate-url-generic-enhancments branch July 17, 2023 12:56
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
@efelmandar @adi88d @xsoar-bot
Ciac-2676/detonate url generic enhancments (demisto#25787)
92e14f0 
* Add toversion and new playbook with image

* Add toversion and new playbook with image

* Add toversion and new playbook with image

* Add toversion and new playbook with image

* Updated playbook with correct sub playbooks names

* Fixed wrong input argument and skipifunavailable

* Update release notes

* Update release notes

* Update release notes description

* Update release notes

* Updated release notes

* Update release notes description

* Fixed validation errors

* Fix validation errors for wrong toversion

* Fixed validation error of wrong fromversion

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.21.

* Update playbook-Detonate_URL_-_Generic.yml

* Fix validation error of unused inputs and missing readme

* Fix validation of unsused inputs in playbook

* Bump pack from version CommonPlaybooks to 2.3.59.

* Bump pack from version CommonPlaybooks to 2.3.60.

* Bump pack from version CrowdStrikeFalconX to 1.2.27.

* Bump pack from version JoeSecurity to 1.1.10.

* Bump pack from version CommonPlaybooks to 2.3.61.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.22.

* Bump pack from version CommonPlaybooks to 2.3.62.

* Bump pack from version CommonPlaybooks to 2.3.63.

* Bump pack from version CommonPlaybooks to 2.3.64.

* Change toversion and fromversion playbook files

* Update release notes

* Update release notes

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.24.

* Bump pack from version CommonPlaybooks to 2.3.65.

* Bump pack from version CommonPlaybooks to 2.3.66.

* Bump pack from version CommonPlaybooks to 2.3.67.

* update sdk version

* revert changes

* Bump pack from version CommonPlaybooks to 2.3.68.

* Update release notes

* Bump pack from version CrowdStrikeFalconX to 1.2.29.

* Bump pack from version CommonPlaybooks to 2.3.70.

* Bump pack from version CommonPlaybooks to 2.3.71.

* Bump pack from version CommonPlaybooks to 2.3.72.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.25.

* Bump pack from version CommonPlaybooks to 2.3.73.

* Update playbook-Detonate_URL_-_Generic.yml

Fix review comments

* Fix review comments

* Fix Review comments

* Update playbook-Detonate_URL_-_Generic_fromversion_6.8.yml

* Update release notes

* Bump pack from version CrowdStrikeFalconX to 1.2.30.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.26.

* Replace playbooks with tasks for wildfire and crowdstrike detonation

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.27.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.28.

* deprecate playbook with generic polling

* Update release notes

* Bump pack from version CrowdStrikeFalconX to 1.2.31.

* Update release notes

* Fix validation errors

* Fix validations

* Changes according to review comments

* Bump pack from version CommonPlaybooks to 2.3.79.

* removed according to comments

* Deprecate old detonate url generic

* Revert "Replace playbooks with tasks for wildfire and crowdstrike detonation"

This reverts commit a4021ac.

* Add new detonate url generic playbook with generic polling commands

* Modify phishing generic to use newer detonate url generic

* Remove outdated release notes

* Revert changes of playbook image

* Update release notes

* Bump pack from version Phishing to 3.5.24.

* Fix validation erros

* Fix validation

* Fix according to review comments

* Fix according to review comments

* Fix according to review comments

* Update playbook-Detonate_URL_-_Generic_v1.5.yml

* Updated release notes

---------

Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Aug 2, 2023
@efelmandar @adi88d @xsoar-bot
Ciac-2676/detonate url generic enhancments (demisto#25787)
ba31b65 
* Add toversion and new playbook with image

* Add toversion and new playbook with image

* Add toversion and new playbook with image

* Add toversion and new playbook with image

* Updated playbook with correct sub playbooks names

* Fixed wrong input argument and skipifunavailable

* Update release notes

* Update release notes

* Update release notes description

* Update release notes

* Updated release notes

* Update release notes description

* Fixed validation errors

* Fix validation errors for wrong toversion

* Fixed validation error of wrong fromversion

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.21.

* Update playbook-Detonate_URL_-_Generic.yml

* Fix validation error of unused inputs and missing readme

* Fix validation of unsused inputs in playbook

* Bump pack from version CommonPlaybooks to 2.3.59.

* Bump pack from version CommonPlaybooks to 2.3.60.

* Bump pack from version CrowdStrikeFalconX to 1.2.27.

* Bump pack from version JoeSecurity to 1.1.10.

* Bump pack from version CommonPlaybooks to 2.3.61.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.22.

* Bump pack from version CommonPlaybooks to 2.3.62.

* Bump pack from version CommonPlaybooks to 2.3.63.

* Bump pack from version CommonPlaybooks to 2.3.64.

* Change toversion and fromversion playbook files

* Update release notes

* Update release notes

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.24.

* Bump pack from version CommonPlaybooks to 2.3.65.

* Bump pack from version CommonPlaybooks to 2.3.66.

* Bump pack from version CommonPlaybooks to 2.3.67.

* update sdk version

* revert changes

* Bump pack from version CommonPlaybooks to 2.3.68.

* Update release notes

* Bump pack from version CrowdStrikeFalconX to 1.2.29.

* Bump pack from version CommonPlaybooks to 2.3.70.

* Bump pack from version CommonPlaybooks to 2.3.71.

* Bump pack from version CommonPlaybooks to 2.3.72.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.25.

* Bump pack from version CommonPlaybooks to 2.3.73.

* Update playbook-Detonate_URL_-_Generic.yml

Fix review comments

* Fix review comments

* Fix Review comments

* Update playbook-Detonate_URL_-_Generic_fromversion_6.8.yml

* Update release notes

* Bump pack from version CrowdStrikeFalconX to 1.2.30.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.26.

* Replace playbooks with tasks for wildfire and crowdstrike detonation

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.27.

* Bump pack from version Palo_Alto_Networks_WildFire to 2.1.28.

* deprecate playbook with generic polling

* Update release notes

* Bump pack from version CrowdStrikeFalconX to 1.2.31.

* Update release notes

* Fix validation errors

* Fix validations

* Changes according to review comments

* Bump pack from version CommonPlaybooks to 2.3.79.

* removed according to comments

* Deprecate old detonate url generic

* Revert "Replace playbooks with tasks for wildfire and crowdstrike detonation"

This reverts commit a4021ac.

* Add new detonate url generic playbook with generic polling commands

* Modify phishing generic to use newer detonate url generic

* Remove outdated release notes

* Revert changes of playbook image

* Update release notes

* Bump pack from version Phishing to 3.5.24.

* Fix validation erros

* Fix validation

* Fix according to review comments

* Fix according to review comments

* Fix according to review comments

* Update playbook-Detonate_URL_-_Generic_v1.5.yml

* Updated release notes

---------

Co-authored-by: Content Bot <bot@demisto.com>
Co-authored-by: adi88d <adaud@paloaltonetworks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@altmannyarden altmannyarden altmannyarden left review comments

@OmriItzhak OmriItzhak OmriItzhak approved these changes

@dorschw dorschw dorschw left review comments

Assignees
No one assigned
Labels
docs-approved
Projects
None yet
Milestone
No milestone
6 participants
@efelmandar @content-bot @altmannyarden @dorschw @OmriItzhak @adi88d