[Cortex XDR] support for multiple endpoint statuses #25792
Conversation
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @samuelFain will know the proposed changes are ready to be reviewed. |
| @@ -766,6 +766,12 @@ script: | |||
| - disconnected | |||
| - lost | |||
| - uninstalled | |||
| - windows | |||
There was a problem hiding this comment.
content-bot
added
Community
Contribution Form Filled
There was a problem hiding this comment.
@ennozdd Thank you so much for your contribution, I appreciate your patience!
Added a few minor comments - please review them.
Also, since you changed xdr-get-endpoints-by-status command status argument to support a list of values, it will be appropriate to change the command argument description accordingly in CortexXDRIR.yml
For example: 'A comma-separated list of endpoint statuses to filter.'
Co-authored-by: samuelFain <65926551+samuelFain@users.noreply.github.com>
Co-authored-by: samuelFain <65926551+samuelFain@users.noreply.github.com>
|
@samuelFain done |
| auto: PREDEFINED | ||
| predefined: |
There was a problem hiding this comment.
Just noticed this,
If we want to allow a comma separated list as a command argument input, we should add isArray: true.
Also, for the same status argument, we have a predefined list of values, which as far as i know allows only one value as an input and not an array.
I think it should be one or the other and not both.
If the intended use is as your screenshot in the PR's description, i think the array option is the way to go here.
(The predefined list of options can be added in the description to help the users).
samuelFain
added
the
pending-contributor
|
@samuelFain done |
samuelFain
removed
the
pending-contributor
There was a problem hiding this comment.
@ennozdd Amazing job!
Please correct this last description to match with the new and better description for status argument, so that we may proceed to merge this PR.
samuelFain
added
the
pending-contributor
Co-authored-by: samuelFain <65926551+samuelFain@users.noreply.github.com>
|
@samuelFain done |
samuelFain
added
docs-approved
ready-for-instance-test
|
For the Reviewer: Successfully created a pipeline in Gitlab with url: https://code.pan.run/xsoar/content/-/pipelines/5052131 |
* added support for multiple statuses * release notes * docker image * fixing units * mypy * mypy errors * release note name change * line ends with . * Update Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR.py * Update Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR.yml * modifications according to comments * from predefined to array * ok * syntax error * Update Packs/CortexXDR/Integrations/CortexXDRIR/CortexXDRIR.yml --------- Co-authored-by: Enes Özdemir <49711791+ennozdd@users.noreply.github.com> Co-authored-by: samuelFain <65926551+samuelFain@users.noreply.github.com>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
Added support for multiple endpoint statuses for the command xdr-get-endpoints-by-status
Screenshots
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have